ADR to use asdf for node as well as golang #386
Conversation
There was a problem hiding this comment.
❌ This PR needs changes ...
Great work on this, @brandonlenz. There's a small typo to address. I added comments on the other files but those were mostly praise or calling out possible fast-follow PRs to this work and are otherwise non-blocking comments around being too specific in the documentation around version numbers changing.
docs/adrs/0081-use-asdf-to-manage-node-and-golang-versions-in-development.md
Outdated
Show resolved
Hide resolved
| * Do nothing, keep using asdf for golang and nodenv for node | ||
| * Use asdf to manage golang and node versions | ||
|
|
||
| ## Decision Outcome |
There was a problem hiding this comment.
questions:
Do we need to mention somewhere here that going forward folks will use asdf? (i.e. if you have been using nodenv in the past, you're still welcome to use nodenv, but new folks will use asdf)
Also, do we want to have a ticket or something else to revisit migrating everyone over? I think getting everyone to use asdf would be useful for being able to help each other.
Other side question. How do folks migrate to using allowing asdf to manage their node version and go version?
There was a problem hiding this comment.
I added a quick guide for switching from Nodenv to asdf:
There was a problem hiding this comment.
Once merged, I do plan on putting out an announcement on slack, and volunteer to help anyone who tries to switch and gets stuck. With these PRs, anyone going through the docs and setup going forward would not be directed to Nodenv
I think a ticket in the backlog to switch everyone over and then remove nodenv related docs once and for all is a good idea
Companion PR to transcom/mymove#11053
Changes