-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MB-16927] Update documentation for project transition #407
Conversation
docs/getting-started/application-setup/03-project-setup-homebrew-vs-nix/README.md
Outdated
Show resolved
Hide resolved
This looks awesome! I did a code search for Truss and am adding everywhere I think we can probably remove or change references to Truss.
|
That's a great point @kingishb-truss -- I wasn't super sure how we want to handle all the instances of Truss-specific language (so far I just removed links to the Truss Slack workspace), but I think your suggestions seem pretty spot on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ This PR needs changes ...
Great work on this @melissathai. I have some changes that I think would help. If others disagree, please dismiss my review so this PR can be merged in at the team's pace. The changes are small here and not all my comments are suggestions. I've prefixed the actual suggestions here with an ❌ emoji.
docs/getting-started/application-setup/03-project-setup-homebrew-vs-nix/01-setup-homebrew.md
Show resolved
Hide resolved
docs/getting-started/application-setup/03-project-setup-homebrew-vs-nix/README.md
Outdated
Show resolved
Hide resolved
… to application-setup
Co-authored-by: Roger Steve Ruiz <[email protected]>
434b385
to
1c88cf4
Compare
Hi @rogeruiz , @kingishb-truss had great questions that I don't know the answer to. Do you have context on these?
I don't see it either. The closest thing I can find is the fresh-brew.local file in
Not sure what to do about the copyright. My guess is that we wouldn't want to remove it until our contract ends on September 30?
Agreed. I removed the command line command, but not sure what to do about the link to the nix search app since it's actually quite useful for nix users. It also seems like the the Switching over to Nix (cc original author, @felipe-lee ) page is more like an investigation/discovery doc than a how-to guide. I wonder if this should be moved over to Confluence, as per the Where should my documentation go guide. |
@@ -28,9 +28,9 @@ If you are using git from the terminal it is worth configuring your user setting | |||
|
|||
1. From the Terminal set the user email and user name to match your GitHub account by changing the values in quotes below one line at a time. | |||
|
|||
`git config --global user.email "[email protected]"` | |||
`git config --global user.email "[email protected]"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙃
|
||
## AWS Services | ||
|
||
This project uses AWS services which means you'll need an account to work with parts of it. AWS credentials are managed via `aws-vault`. Once you have received AWS credentials (which are provided by the infrastructure team), follow these instructions to [finish setting up AWS](https://dp3.atlassian.net/wiki/spaces/MT/pages/1250066433/0029+AWS+Organization+Authentication). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment: I've never really understood why the mymove
project is open-source when you need credentials supplied by our infrastructure team in order to develop on it. Just food for thought 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a good example of the borders between how we work and how our compliance and contracts. It's a balance. Technically speaking, you could standup an AWS environment with the similar inputs/outputs needed to run the application locally. I believe that one of the decisions here to use tools like aws-vault
is that it was easier on the developer experience as well. But this is a great topic for the engineering guilds on the Truss-side to discuss further.
Yes I think this is something we can remove from the |
I don't think we'd want to touch the contract, but perhaps we could change the show date to not sure a date passed 2023 that involves Truss? That might be a good compromise here. It's also likely that the license could change in the future by USTC. |
So this application was created by @ahobson to support Trussels using Nix. I'd ask him directly to see if there's a plan to place it under the TrussWorks organization rather than his own. I know Nix is still considered experimentally internally and not just on the USTC project.
I would push back a little on moving this into Confluence since Nix is still experimental. But I'm not against moving it if others agree with you here. My reasoning is that rather than moving it to Confluence, we just remove it from our documentation all together. We could then move this specific Nix setup to something like our Truss Engineering Playbook since it's still an experiment for the Engineering practices. |
Sounds good. Maybe we can take that conversation offline and put up another PR updating the respective links when a decision is made.
Also sounds good to me. I'll leave it here for now and remove it once it's been migrated to the Truss Engineering Playbook. |
@@ -142,7 +142,8 @@ module.exports = { | |||
], | |||
}, | |||
], | |||
copyright: `Copyright ${new Date().getFullYear()} U.S. Federal Government (in countries where recognized) and TrussWorks. Built with Docusaurus.`, | |||
// Truss contract ends in 2023. Do not show a date that surpasses 2023 that involves Truss. | |||
copyright: `Copyright ${Math.min(new Date().getFullYear(), 2023)} U.S. Federal Government (in countries where recognized) and TrussWorks. Built with Docusaurus.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated copyright
dismissing this as it's a Stale review now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🌈
Great work on this @melissathai. 🚀
Context
As we prepare to transition MilMove over, the MilMove Developer Portal should be updated to ensure a smooth transition to whoever this project passes on to. Refer to the discovery docs for more details.
This PR mostly focuses on updating the "About" section of the developer docs. The remaining sections ("Frontend", "Backend", "API", etc) will be updated in future PRs
NOTE FOR REVIEWERS: The best way to review these changes is to pull this branch and look over the new docs locally.
Changes Made
Screenshots
Added more context in the Homebrew vs Nix setup:
Added troubleshooting section to database setup instructions:
Added instructions and screenshots for running the app locally as a service member, admin, and office worker:
Testing