Skip to content

Commit

Permalink
Syncing node version with latest version in container
Browse files Browse the repository at this point in the history
  • Loading branch information
reggieriser committed Mar 5, 2021
1 parent 1702f0b commit d0b00de
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/analyze-bundle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Set up node
uses: actions/setup-node@v1
with:
node-version: '12.16.3'
node-version: '12.21.0'

- name: Install dependencies
run: yarn install
Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:
- name: Set up node
uses: actions/setup-node@v1
with:
node-version: '12.16.3'
node-version: '12.21.0'

- name: Install dependencies
run: yarn install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/happo-tests-master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Set up node
uses: actions/setup-node@v1
with:
node-version: '12.16.3'
node-version: '12.21.0'

- name: Install dependencies
run: yarn install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/happo-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Set up node
uses: actions/setup-node@v1
with:
node-version: '12.16.3'
node-version: '12.21.0'

- name: Install dependencies
run: yarn install
Expand Down
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
12.16.3
12.21.0
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
default_language_version:
# this should match the version in .node-version at the root of this project
node: 12.16.3
node: 12.21.0

repos:
- repo: local
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ You can feel free to skip running the pre-commit checks at this time. Before you

#### Troubleshooting install issues (process hanging on install hooks)

Since pre-commit uses node to hook things up in both your local repo and its cache folder (located at `~/.cache/pre-commit`),it requires a global node install. If you are using nodenv to manage multiple installed nodes, you'll need to set a global version to proceed (eg `nodenv global 12.16.3`). You can find the current supported node version [here (in `.node-version`)](./.node-version). Make sure you run `nodenv install` to install the current supported version.
Since pre-commit uses node to hook things up in both your local repo and its cache folder (located at `~/.cache/pre-commit`),it requires a global node install. If you are using nodenv to manage multiple installed nodes, you'll need to set a global version to proceed (eg `nodenv global 12.21.0`). You can find the current supported node version [here (in `.node-version`)](./.node-version). Make sure you run `nodenv install` to install the current supported version.

### Setup: Dependencies

Expand Down
2 changes: 1 addition & 1 deletion scripts/prereqs
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ has shellcheck "brew install shellcheck"
has psql "brew install postgresql"
has nodenv "brew install nodenv"
has_path ".nodenv/shims" "nodenv init"
has node "nodenv local 12.16.3"
has node "nodenv local 12.21.0"

# not on CircleCI
if [[ -z ${CIRCLECI-} ]]; then
Expand Down

0 comments on commit d0b00de

Please sign in to comment.