Swallow malformed messages on trigger bucket topics #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phildobsontw
force-pushed
the
swallow-malformed-messages
branch
3 times, most recently
from
5c5189d to
781a3fc
Compare
phildobsontw
force-pushed
the
swallow-malformed-messages
branch
from
781a3fc to
b94f9c1
Compare
onukristo
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
At the moment, we're vulnerable to poison pill attacks on our trigger bucket topics (i.e.
twTasks.{service-name}.executeTask.{bucket-name}).This issue will be resolved by detecting malformed messages when deserialising to JSON, and in these cases we will just log the error (including topic-partition and offset so that the issue can be looked into) but then continue processing rather than getting stuck in a retry-loop.
Checklist