traverse parents if span exists

travisbrown · Dec 13, 2019 · dc1e127 · dc1e127
1 parent 69f3d60
commit dc1e127
Show file tree

Hide file tree

Showing 5 changed files with 46 additions and 53 deletions.
diff --git a/compiler/src/dotty/tools/dotc/semanticdb/ExtractSemanticDB.scala b/compiler/src/dotty/tools/dotc/semanticdb/ExtractSemanticDB.scala
@@ -170,13 +170,8 @@ class ExtractSemanticDB extends Phase with
           if !excludeDef(ctorSym)
             registerDefinition(ctorSym, tree.constr.span, Set.empty)
             ctorParams(tree.constr.vparamss, tree.body)(traverseCtorParamTpt(ctorSym, _))
-          for parent <- tree.parentsOrDerived do
-            if
-              parent.symbol != defn.ObjectClass.primaryConstructor
-              && parent.tpe.dealias != defn.SerializableType
-              && parent.symbol != defn.ProductClass
-            then
-              traverse(parent)
+          for parent <- tree.parentsOrDerived if parent.span.hasLength do
+            traverse(parent)
           val selfSpan = tree.self.span
           if selfSpan.exists && selfSpan.hasLength then
             traverse(tree.self)

diff --git a/compiler/src/dotty/tools/dotc/semanticdb/Tools.scala b/compiler/src/dotty/tools/dotc/semanticdb/Tools.scala
@@ -43,7 +43,7 @@ object Tools with
     val realURI = realPath.toString
     given SourceFile = SourceFile.virtual(doc.uri, doc.text)
     sb.append(realURI).nl
-    sb.append("_" * realURI.length).nl
+    sb.append("-" * realURI.length).nl
     sb.nl
     sb.append("Summary:").nl
     sb.append("Schema => ").append(schemaString(doc.schema)).nl

diff --git a/tests/semanticdb/expect/filename with spaces.expect.scala b/tests/semanticdb/expect/filename with spaces.expect.scala
@@ -1,3 +1,3 @@
 package example
 
-class FilenameWithSpaces/*<-example::FilenameWithSpaces#*//*<=example.FilenameWithSpaces#*/
+class FilenameWithSpaces/*<-example::FilenameWithSpaces#*/
diff --git a/tests/semanticdb/expect/filename with spaces.scala b/tests/semanticdb/expect/filename with spaces.scala
@@ -1,3 +1,3 @@
 package example
 
-class FilenameWithSpaces/*<=example.FilenameWithSpaces#*/
+class FilenameWithSpaces