forked from pantsbuild/pants
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix broken export-classpath (pantsbuild#4603)
### Problem I'd assumed that ClassPathUtils.classpath would take just the root targets, and that it didn't apply excludes correctly when the closure was passed. That was incorrect. Doing that would cause export-classpath to return an invalid classpath ### Solution Revert that change, and update the regression test to be more comprehensive. ### Result export-classpath works correctly again, and the regression test covers the excludes case more effectively.
- Loading branch information
1 parent
eaf036b
commit c0a8b21
Showing
3 changed files
with
9 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters