Skip to content
This repository has been archived by the owner on Sep 4, 2021. It is now read-only.

Main page logo changed by screenshot #10

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

Nivedita967
Copy link
Contributor

I have replaced Logo in the main page by screenshot. Check if it is looking better or not.

index.html Outdated
@@ -143,8 +143,11 @@ <h1>
<div class="image-container">
<img
class="img-fluid"
src="img/ic_launcher-web.png"
src="img/shot_1.webp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might look nicer if the screenshot were showing an in-app view IMO. Other than that, it is approvable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, a screenshot of maybe the home page when the app is opened would be preferred over the web UI of trebleshot. This screenshot seems to be a better candidate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I am trying to do changes according to you.

@ptanmay143
Copy link
Contributor

  • It would be better if the screenshot could have been wrapped inside a phone vector. See this example.
  • The GitHub icon in the top right (and the one at the extreme bottom) has almost zero visibility due to the background and foreground colors cancelling each other out.
  • The stats at the bottom of the page have been changed as follows:
    Issues: 68 -> 79
    Stars: 417 -> 570
    Downloads: Play Store still shows 10,000+ downloads. 👍

@Nivedita967
Copy link
Contributor Author

I have done changes, please review.

Copy link
Member

@velitasali velitasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Thanks for the help.

BTW, there is an unnecessary file named "git" in the root folder, but it is not a dealbreaker :)

@velitasali
Copy link
Member

  • The GitHub icon in the top right (and the one at the extreme bottom) has almost zero visibility due to the background and foreground colors cancelling each other out.

We can discuss this by opening another issue.

  • The stats at the bottom of the page have been changed as follows:
    Issues: 68 -> 79
    Stars: 417 -> 570
    Downloads: Play Store still shows 10,000+ downloads. +1

Yes, I mentioned it in #7.

@velitasali velitasali merged commit 93578bf into trebleshot:master Sep 24, 2020
@velitasali velitasali mentioned this pull request Sep 24, 2020
7 tasks
@Nivedita967
Copy link
Contributor Author

It looks good. Thanks for the help.

BTW, there is an unnecessary file named "git" in the root folder, but it is not a dealbreaker :)

I have not added this git file and don't even noticed. You may delete this :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants