Skip to content

Commit

Permalink
fix missing manual_wal_flush for DBOptions ctor
Browse files Browse the repository at this point in the history
Summary:
currently `ImmutableDBOptions::Dump` use default value for `concurrent_prepare` and `manual_wal_flush`, because DBOptions ctor does not init those member variables.

so in LOG file,  it will be
```
             Options.concurrent_prepare: 0
             Options.manual_wal_flush: 0
```
Closes facebook#2864

Differential Revision: D5816240

Pulled By: ajkr

fbshipit-source-id: 82335e8bcae3dceedc6a99224e7998de5fad1e50
  • Loading branch information
lishuai87 authored and facebook-github-bot committed Sep 13, 2017
1 parent 5785b1f commit f615f56
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion options/options.cc
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,9 @@ DBOptions::DBOptions(const Options& options)
dump_malloc_stats(options.dump_malloc_stats),
avoid_flush_during_recovery(options.avoid_flush_during_recovery),
avoid_flush_during_shutdown(options.avoid_flush_during_shutdown),
allow_ingest_behind(options.allow_ingest_behind) {
allow_ingest_behind(options.allow_ingest_behind),
concurrent_prepare(options.concurrent_prepare),
manual_wal_flush(options.manual_wal_flush) {
}

void DBOptions::Dump(Logger* log) const {
Expand Down

0 comments on commit f615f56

Please sign in to comment.