-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for Loki connector #24844
Add docs for Loki connector #24844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for starting the documentation 🙏
|
||
```text | ||
connector.name=loki | ||
loki.uri=http://loki.example.com:3100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also loki.auth.user
and loki.auth.password
that can be set to a Basic auth credentials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, #24830 removed those config properties since they were unused.
Please restore with tests if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm .. should I take them out for now here as well then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed them for now so we can actually merge the docs PR .. if you reintroduce them in code .. please also update docs @jeschkies
Awesome @jeschkies ..thanks for all the info .. I am working on 470 release notes but will pick this up afterwards .. |
df7f11e
to
3e5502b
Compare
@jeschkies @ebyhr and @Praveen2112 .. I think this is good to go now .. have a look and check technical details and my examples please. |
I think we should ship this before the release on Wednesday .. any further changes needed? @jeschkies @ebyhr and @Praveen2112 |
Thank you @ebyhr |
Description
Minimal docs to allow us to ship with connector in same release. Still working on details .. input welcome.
Additional context and related issues
#23053
#24838
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.