Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for Loki connector #24844

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Add docs for Loki connector #24844

merged 1 commit into from
Feb 3, 2025

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Jan 29, 2025

Description

Minimal docs to allow us to ship with connector in same release. Still working on details .. input welcome.

Additional context and related issues

#23053
#24838

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Copy link
Member

@jeschkies jeschkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for starting the documentation 🙏

docs/src/main/sphinx/connector/loki.md Show resolved Hide resolved

```text
connector.name=loki
loki.uri=http://loki.example.com:3100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also loki.auth.user and loki.auth.password that can be set to a Basic auth credentials.

Copy link
Member

@ebyhr ebyhr Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, #24830 removed those config properties since they were unused.
Please restore with tests if you want.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm .. should I take them out for now here as well then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed them for now so we can actually merge the docs PR .. if you reintroduce them in code .. please also update docs @jeschkies

docs/src/main/sphinx/connector/loki.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/loki.md Outdated Show resolved Hide resolved
@mosabua
Copy link
Member Author

mosabua commented Jan 31, 2025

Awesome @jeschkies ..thanks for all the info .. I am working on 470 release notes but will pick this up afterwards ..

@mosabua mosabua force-pushed the lokidocs branch 2 times, most recently from df7f11e to 3e5502b Compare January 31, 2025 22:49
@mosabua mosabua marked this pull request as ready for review January 31, 2025 22:50
@mosabua
Copy link
Member Author

mosabua commented Jan 31, 2025

@jeschkies @ebyhr and @Praveen2112 .. I think this is good to go now .. have a look and check technical details and my examples please.

@mosabua
Copy link
Member Author

mosabua commented Feb 3, 2025

I think we should ship this before the release on Wednesday .. any further changes needed? @jeschkies @ebyhr and @Praveen2112

@mosabua
Copy link
Member Author

mosabua commented Feb 3, 2025

Thank you @ebyhr

@mosabua mosabua merged commit 87cd275 into trinodb:master Feb 3, 2025
8 checks passed
@mosabua mosabua deleted the lokidocs branch February 3, 2025 23:45
@github-actions github-actions bot added this to the 470 milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants