Do not use sprintf without a format

trishika · Mar 24, 2008 · 8956173 · 8956173
1 parent 308aaf6
commit 8956173
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/text/strings.c b/src/text/strings.c
@@ -659,7 +659,8 @@ char *__str_format_meta( vlc_object_t *p_object, const char *string )
     int b_empty_if_na = 0;
     char buf[10];
     int i_size = strlen( string ) + 1; /* +1 to store '\0' */
-    char *dst = malloc( i_size );
+    char *dst = strdup( string );
+    if( !dst ) return NULL;
     int d = 0;
 
     playlist_t *p_playlist = pl_Yield( p_object );
@@ -672,8 +673,6 @@ char *__str_format_meta( vlc_object_t *p_object, const char *string )
         p_item = input_GetItem(p_input);
     }
 
-    sprintf( dst, string );
-
     while( *s )
     {
         if( b_is_format )