Skip to content

Commit

Permalink
Bug 1530031 - Summary: Allow ARM64 Simulator to return a different er…
Browse files Browse the repository at this point in the history
…ror message. r=nbp

Differential Revision: https://phabricator.services.mozilla.com/D21288

--HG--
extra : moz-landing-system : lando
  • Loading branch information
sstangl committed Feb 27, 2019
1 parent b9e3808 commit 16371d0
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions js/src/jsapi-tests/testChromeBuffer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,17 @@ BEGIN_TEST(testChromeBuffer) {

JS::RootedValue rval(cx);
CHECK(JS_CallFunction(cx, nullptr, fun, JS::HandleValueArray(v), &rval));
#ifndef JS_SIMULATOR_ARM64
// The ARM64 simulator does not share a common implementation with the other
// simulators, and has slightly different end-of-stack behavior. Instead of
// failing with "too much recursion," it executes one more function call and
// fails with a type error. This behavior is not incorrect.
bool match;
CHECK(JS_StringEqualsAscii(
cx, rval.toString(), "From trusted: InternalError: too much recursion",
&match));
CHECK(match);
#endif
}

{
Expand Down

0 comments on commit 16371d0

Please sign in to comment.