Bug 1478184 - fix handling of html comments in parseDeclarations; r=gl

parseDeclarations was ignoring html comment tokens, but in fact they
should not be treated any differently from other CSS tokens.

MozReview-Commit-ID: 27Mxt5zbSSJ

--HG--
extra : amend_source : 91e47bbf6951ac9dd4709ac10c49ff51c1781ce8

devtools/client/shared/test/unit/test_parseDeclarations.js

@@ -374,15 +374,15 @@ const TEST_DATA = [
                 offsets: [3, 30], commentOffsets: [0, 33]}]
   },
 
-  // HTML comments are ignored.
+  // HTML comments are not special -- they are just ordinary tokens.
   {
     parseComments: true,
     input: "<!-- color: red; --> color: blue;",
     expected: [
-      {name: "color", value: "red", priority: "",
-       offsets: [5, 16]},
-      {name: "color", value: "blue", priority: "",
-       offsets: [21, 33]}]
+      {name: "<!-- color", value: "red", priority: "",
+       offsets: [0, 16]},
+      {name: "--> color", value: "blue", priority: "",
+       offsets: [17, 33]}]
   },
 
   // Don't error on an empty comment.

devtools/shared/css/parsing-utils.js

@@ -318,12 +318,6 @@ function parseDeclarationsInternal(isCssPropertyKnown, inputString,
       break;
     }
 
-    // Ignore HTML comment tokens (but parse anything they might
-    // happen to surround).
-    if (token.tokenType === "htmlcomment") {
-      continue;
-    }
-
     // Update the start and end offsets of the declaration, but only
     // when we see a significant token.
     if (token.tokenType !== "whitespace" && token.tokenType !== "comment") {