Skip to content

Commit

Permalink
Bug 1539779 - clang-tidy 8 mixes stderr and stdout causing parsing is…
Browse files Browse the repository at this point in the history
…sues. r=sylvestre

Differential Revision: https://phabricator.services.mozilla.com/D25255

--HG--
extra : moz-landing-system : lando
  • Loading branch information
abpostelnicu committed Mar 29, 2019
1 parent 437397c commit 2473b50
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 0 deletions.
11 changes: 11 additions & 0 deletions build/build-clang/clang-tidy-8.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
--- a/extra/clang-tidy/tool/run-clang-tidy.py 2019-03-27 15:12:48.000000000 +0200
+++ b/extra/clang-tidy/tool/run-clang-tidy.py 2019-03-27 15:12:39.000000000 +0200
@@ -169,7 +169,7 @@
with lock:
sys.stdout.write(' '.join(invocation) + '\n' + output.decode('utf-8') + '\n')
if len(err) > 0:
- sys.stderr.write(err.decode('utf-8') + '\n')
+ sys.stdout.write(err.decode('utf-8') + '\n')
queue.task_done()


1 change: 1 addition & 0 deletions build/build-clang/clang-tidy-linux64.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@
"cxx": "/builds/worker/workspace/build/src/gcc/bin/g++",
"as": "/builds/worker/workspace/build/src/gcc/bin/gcc",
"patches": [
"clang-tidy-8.patch"
]
}
1 change: 1 addition & 0 deletions build/build-clang/clang-tidy-macosx64.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@
"libtool": "/builds/worker/workspace/build/src/cctools/bin/x86_64-darwin11-libtool",
"ld": "/builds/worker/workspace/build/src/clang/bin/clang",
"patches": [
"clang-tidy-8.patch"
]
}
1 change: 1 addition & 0 deletions build/build-clang/clang-tidy-win64.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@
"cxx": "cl.exe",
"ml": "ml64.exe",
"patches": [
"clang-tidy-8.patch"
]
}

0 comments on commit 2473b50

Please sign in to comment.