Skip to content

Commit

Permalink
Bug 903135 - Multi platform MAR verification build config. r=rstrong
Browse files Browse the repository at this point in the history
  • Loading branch information
bbondy committed Oct 23, 2014
1 parent 6a47404 commit 598238b
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 11 deletions.
7 changes: 7 additions & 0 deletions browser/confvars.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,15 @@ if test "$OS_ARCH" = "WINNT"; then
fi
fi
fi
elif test "$OS_ARCH" = "Linux"; then
MOZ_VERIFY_MAR_SIGNATURE=1
elif test "$OS_ARCH" = "Darwin"; then
MOZ_VERIFY_MAR_SIGNATURE=1
fi

# Enable building ./signmar and running libmar signature tests
MOZ_ENABLE_SIGNMAR=1

MOZ_CHROME_FILE_FORMAT=omni
MOZ_DISABLE_EXPORT_JS=1
MOZ_SAFE_BROWSING=1
Expand Down
6 changes: 1 addition & 5 deletions configure.in
Original file line number Diff line number Diff line change
Expand Up @@ -6425,11 +6425,7 @@ MOZ_ARG_ENABLE_BOOL(verify-mar,
MOZ_VERIFY_MAR_SIGNATURE= )

if test -n "$MOZ_VERIFY_MAR_SIGNATURE"; then
if test "$OS_ARCH" = "WINNT"; then
AC_DEFINE(MOZ_VERIFY_MAR_SIGNATURE)
else
AC_MSG_ERROR([Can only build with --enable-verify-mar with a Windows target])
fi
AC_DEFINE(MOZ_VERIFY_MAR_SIGNATURE)
fi

dnl ========================================================
Expand Down
6 changes: 1 addition & 5 deletions modules/libmar/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,7 @@ DIRS += ['src']
if CONFIG['MOZ_ENABLE_SIGNMAR']:
DIRS += ['sign', 'verify']
TEST_DIRS += ['tests']
elif CONFIG['OS_ARCH'] == 'WINNT':
# On Windows we don't verify with NSS and updater needs to link to it
DIRS += ['verify']
elif CONFIG['OS_ARCH'] == 'Darwin':
# On OSX we don't verify with NSS and updater needs to link to it.
elif CONFIG['MOZ_VERIFY_MAR_SIGNATURE']:
DIRS += ['verify']

# If we are building ./sign and ./verify then ./tool must come after it
Expand Down
7 changes: 6 additions & 1 deletion toolkit/mozapps/update/updater/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,12 @@ if CONFIG['OS_ARCH'] == 'WINNT':
else:
USE_LIBS += [
'updatecommon',
'/modules/libmar/sign/signmar',
'/modules/libmar/sign/verifymar',
'/security/nss/lib/nss/nss3',
'/security/nss/lib/util/nssutil3',
]
OS_LIBS += CONFIG['NSPR_LIBS']

USE_LIBS += [
'mar',
Expand All @@ -70,7 +75,7 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'cocoa':
'launchchild_osx.mm',
'progressui_osx.mm',
]
OS_LIBS += ['-framework Cocoa']
OS_LIBS += ['-framework Cocoa -framework Security']
elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk':
have_progressui = 1
SOURCES += [
Expand Down

0 comments on commit 598238b

Please sign in to comment.