Skip to content

Commit

Permalink
Bug 1510478 - Disable clang-formatting for XPTCall stub files. r=Ehsan
Browse files Browse the repository at this point in the history
Many of the inline assembly macros in these files get reformatted
poorly by clang-format, so don't format them for now. In followup
work, in bug 1510781, hopefully we can write a larger patch to only
disable clang-format for the specific macros and then format the rest
of the files.

The problematic include STUB_ENTRY and STUB_MANGLED_ENTRY.

Differential Revision: https://phabricator.services.mozilla.com/D13311

--HG--
extra : moz-landing-system : lando
  • Loading branch information
amccreight committed Nov 28, 2018
1 parent b8e492e commit 7981e42
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .clang-format-ignore
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ intl/unicharutil/util/nsUnicodePropertyData.cpp
intl/unicharutil/util/nsUnicodeScriptCodes.h
media/mp4parse-rust/mp4parse.h

# The XPTCall stubs files have some inline assembly macros
# that get reformatted badly. See bug 1510781.
xpcom/reflect/xptcall/md/win32/.*
xpcom/reflect/xptcall/md/unix/.*

# Generated from ./tools/rewriting/ThirdPartyPaths.txt
# awk '{print ""$1".*"}' ./tools/rewriting/ThirdPartyPaths.txt
browser/components/translation/cld2/.*
Expand Down

0 comments on commit 7981e42

Please sign in to comment.