Backed out 2 changesets (bug 1465060) for build bustages on security/…

…sandbox/linux/reporter/SandboxReporter.cpp Backed out changeset 7c8905b6b226 (bug 1465060) Backed out changeset 10446073eca8 (bug 1465060)
trman · Jun 3, 2018 · 7e765f7 · 7e765f7
1 parent 9a6bff4
commit 7e765f7
Show file tree

Hide file tree

Showing 89 changed files with 182 additions and 192 deletions.
diff --git a/accessible/ipc/other/ProxyAccessible.cpp b/accessible/ipc/other/ProxyAccessible.cpp
@@ -78,7 +78,7 @@ ProxyAccessible::RelationByType(RelationType aType) const
     if (ProxyAccessible* proxy = mDoc->GetAccessible(targetIDs[i]))
       targets.AppendElement(proxy);
 
-  return targets;
+  return std::move(targets);
 }
 
 void

diff --git a/build/moz.configure/warnings.configure b/build/moz.configure/warnings.configure
@@ -86,6 +86,12 @@ check_and_add_gcc_warning('-Wno-inline-new-delete', cxx_compiler)
 # too many false positives
 check_and_add_gcc_warning('-Wno-error=maybe-uninitialized')
 
+# Turned on by -Wall, but needs changes to be turned into an error
+# (bug 1465060).
+check_and_add_gcc_warning('-Wno-error=pessimizing-move')
+# This one is probably easier, it's only triggered by tests.
+check_and_add_gcc_warning('-Wno-error=self-move')
+
 # we don't want our builds held hostage when a platform-specific API
 # becomes deprecated.
 check_and_add_gcc_warning('-Wno-error=deprecated-declarations')

diff --git a/devtools/shared/heapsnapshot/DeserializedNode.cpp b/devtools/shared/heapsnapshot/DeserializedNode.cpp
@@ -87,8 +87,8 @@ class DeserializedEdgeRange : public EdgeRange
 
     auto& edge = node->edges[i];
     auto referent = node->getEdgeReferent(edge);
-    currentEdge = Edge(edge.name
-                ? NS_strdup(edge.name) : nullptr, referent);
+    currentEdge = std::move(Edge(edge.name ? NS_strdup(edge.name) : nullptr,
+                                     referent));
     front_ = &currentEdge;
   }
 

diff --git a/docshell/base/nsDocShell.cpp b/docshell/base/nsDocShell.cpp
@@ -2865,7 +2865,7 @@ nsDocShell::GetInitialClientInfo() const
   if (mInitialClientSource) {
     Maybe<ClientInfo> result;
     result.emplace(mInitialClientSource->Info());
-    return result;
+    return std::move(result);
   }
 
   nsGlobalWindowInner* innerWindow =
@@ -14067,10 +14067,10 @@ nsDocShell::NotifyJSRunToCompletionStart(const char* aReason,
   if (mJSRunToCompletionDepth == 0) {
     RefPtr<TimelineConsumers> timelines = TimelineConsumers::Get();
     if (timelines && timelines->HasConsumer(this)) {
-      timelines->AddMarkerForDocShell(this,
+      timelines->AddMarkerForDocShell(this, std::move(
         mozilla::MakeUnique<JavascriptTimelineMarker>(
           aReason, aFunctionName, aFilename, aLineNumber, MarkerTracingType::START,
-          aAsyncStack, aAsyncCause));
+          aAsyncStack, aAsyncCause)));
     }
   }
 

diff --git a/docshell/base/timeline/AutoRestyleTimelineMarker.cpp b/docshell/base/timeline/AutoRestyleTimelineMarker.cpp
@@ -32,10 +32,10 @@ AutoRestyleTimelineMarker::AutoRestyleTimelineMarker(
   }
 
   mDocShell = aDocShell;
-  timelines->AddMarkerForDocShell(mDocShell,
+  timelines->AddMarkerForDocShell(mDocShell, std::move(
     MakeUnique<RestyleTimelineMarker>(
       mIsAnimationOnly,
-      MarkerTracingType::START));
+      MarkerTracingType::START)));
 }
 
 AutoRestyleTimelineMarker::~AutoRestyleTimelineMarker()
@@ -51,10 +51,10 @@ AutoRestyleTimelineMarker::~AutoRestyleTimelineMarker()
     return;
   }
 
-  timelines->AddMarkerForDocShell(mDocShell,
+  timelines->AddMarkerForDocShell(mDocShell, std::move(
     MakeUnique<RestyleTimelineMarker>(
       mIsAnimationOnly,
-      MarkerTracingType::END));
+      MarkerTracingType::END)));
 }
 
 } // namespace mozilla
diff --git a/docshell/base/timeline/TimelineConsumers.cpp b/docshell/base/timeline/TimelineConsumers.cpp
@@ -185,7 +185,7 @@ TimelineConsumers::AddMarkerForDocShell(nsDocShell* aDocShell,
 {
   MOZ_ASSERT(NS_IsMainThread());
   if (HasConsumer(aDocShell)) {
-    aDocShell->mObserved->AddMarker(MakeUnique<TimelineMarker>(aName, aTracingType, aStackRequest));
+    aDocShell->mObserved->AddMarker(std::move(MakeUnique<TimelineMarker>(aName, aTracingType, aStackRequest)));
   }
 }
 
@@ -198,7 +198,7 @@ TimelineConsumers::AddMarkerForDocShell(nsDocShell* aDocShell,
 {
   MOZ_ASSERT(NS_IsMainThread());
   if (HasConsumer(aDocShell)) {
-    aDocShell->mObserved->AddMarker(MakeUnique<TimelineMarker>(aName, aTime, aTracingType, aStackRequest));
+    aDocShell->mObserved->AddMarker(std::move(MakeUnique<TimelineMarker>(aName, aTime, aTracingType, aStackRequest)));
   }
 }
 

diff --git a/dom/animation/EffectSet.h b/dom/animation/EffectSet.h
@@ -90,7 +90,7 @@ class EffectSet
   public:
     explicit Iterator(EffectSet& aEffectSet)
       : mEffectSet(aEffectSet)
-      , mHashIterator(aEffectSet.mEffects.Iter())
+      , mHashIterator(std::move(aEffectSet.mEffects.Iter()))
       , mIsEndIterator(false)
     {
 #ifdef DEBUG

diff --git a/dom/base/CustomElementRegistry.cpp b/dom/base/CustomElementRegistry.cpp
@@ -493,7 +493,7 @@ CustomElementRegistry::CreateCustomElementCallback(
   if (aAdoptedCallbackArgs) {
     callback->SetAdoptedCallbackArgs(*aAdoptedCallbackArgs);
   }
-  return callback;
+  return std::move(callback);
 }
 
 /* static */ void

diff --git a/dom/base/nsContentPermissionHelper.cpp b/dom/base/nsContentPermissionHelper.cpp
@@ -432,7 +432,7 @@ nsContentPermissionUtils::GetContentPermissionRequestParentById(const TabId& aTa
     }
   }
 
-  return parentArray;
+  return std::move(parentArray);
 }
 
 /* static */ void
@@ -455,7 +455,7 @@ nsContentPermissionUtils::GetContentPermissionRequestChildById(const TabId& aTab
     }
   }
 
-  return childArray;
+  return std::move(childArray);
 }
 
 /* static */ void

diff --git a/dom/base/nsDocument.cpp b/dom/base/nsDocument.cpp
@@ -5565,29 +5565,29 @@ nsIDocument::GetClientInfo() const
 {
   nsPIDOMWindowInner* inner = GetInnerWindow();
   if (inner) {
-    return inner->GetClientInfo();
+    return std::move(inner->GetClientInfo());
   }
-  return Maybe<ClientInfo>();
+  return std::move(Maybe<ClientInfo>());
 }
 
 Maybe<ClientState>
 nsIDocument::GetClientState() const
 {
   nsPIDOMWindowInner* inner = GetInnerWindow();
   if (inner) {
-    return inner->GetClientState();
+    return std::move(inner->GetClientState());
   }
-  return Maybe<ClientState>();
+  return std::move(Maybe<ClientState>());
 }
 
 Maybe<ServiceWorkerDescriptor>
 nsIDocument::GetController() const
 {
   nsPIDOMWindowInner* inner = GetInnerWindow();
   if (inner) {
-    return inner->GetController();
+    return std::move(inner->GetController());
   }
-  return Maybe<ServiceWorkerDescriptor>();
+  return std::move(Maybe<ServiceWorkerDescriptor>());
 }
 
 //

diff --git a/dom/base/nsGlobalWindowInner.cpp b/dom/base/nsGlobalWindowInner.cpp
@@ -2320,25 +2320,25 @@ nsPIDOMWindowInner::SyncStateFromParentWindow()
 Maybe<ClientInfo>
 nsPIDOMWindowInner::GetClientInfo() const
 {
-  return nsGlobalWindowInner::Cast(this)->GetClientInfo();
+  return std::move(nsGlobalWindowInner::Cast(this)->GetClientInfo());
 }
 
 Maybe<ClientState>
 nsPIDOMWindowInner::GetClientState() const
 {
-  return nsGlobalWindowInner::Cast(this)->GetClientState();
+  return std::move(nsGlobalWindowInner::Cast(this)->GetClientState());
 }
 
 Maybe<ServiceWorkerDescriptor>
 nsPIDOMWindowInner::GetController() const
 {
-  return nsGlobalWindowInner::Cast(this)->GetController();
+  return std::move(nsGlobalWindowInner::Cast(this)->GetController());
 }
 
 RefPtr<mozilla::dom::ServiceWorker>
 nsPIDOMWindowInner::GetOrCreateServiceWorker(const mozilla::dom::ServiceWorkerDescriptor& aDescriptor)
 {
-  return nsGlobalWindowInner::Cast(this)->GetOrCreateServiceWorker(aDescriptor);
+  return std::move(nsGlobalWindowInner::Cast(this)->GetOrCreateServiceWorker(aDescriptor));
 }
 
 void
@@ -5498,7 +5498,7 @@ nsGlobalWindowInner::ShowSlowScriptDialog(const nsString& aAddonId)
 
     // GetStringFromName can return NS_OK and still give nullptr string
     failed = failed || NS_FAILED(rv) || result.IsEmpty();
-    return result;
+    return std::move(result);
   };
 
   bool isAddonScript = !aAddonId.IsEmpty();
@@ -6329,7 +6329,7 @@ nsGlobalWindowInner::GetClientInfo() const
   if (mClientSource) {
     clientInfo.emplace(mClientSource->Info());
   }
-  return clientInfo;
+  return std::move(clientInfo);
 }
 
 Maybe<ClientState>
@@ -6344,7 +6344,7 @@ nsGlobalWindowInner::GetClientState() const
       clientState.emplace(state);
     }
   }
-  return clientState;
+  return std::move(clientState);
 }
 
 Maybe<ServiceWorkerDescriptor>
@@ -6355,7 +6355,7 @@ nsGlobalWindowInner::GetController() const
   if (mClientSource) {
     controller = mClientSource->GetController();
   }
-  return controller;
+  return std::move(controller);
 }
 
 RefPtr<ServiceWorker>

diff --git a/dom/canvas/ImageBitmap.cpp b/dom/canvas/ImageBitmap.cpp
@@ -804,7 +804,7 @@ ImageBitmap::ToCloneData() const
   result->mSurface = surface->GetDataSurface();
   MOZ_ASSERT(result->mSurface);
 
-  return result;
+  return std::move(result);
 }
 
 /* static */ already_AddRefed<ImageBitmap>

diff --git a/dom/canvas/WebGLFormats.cpp b/dom/canvas/WebGLFormats.cpp
@@ -827,7 +827,7 @@ FormatUsageAuthority::CreateForWebGL1(gl::GLContext* gl)
     if (!AddUnsizedFormats(ptr, gl))
         return nullptr;
 
-    return ret;
+    return std::move(ret);
 }
 
 UniquePtr<FormatUsageAuthority>
@@ -1062,7 +1062,7 @@ FormatUsageAuthority::CreateForWebGL2(gl::GLContext* gl)
 
     ////////////////////////////////////
 
-    return ret;
+    return std::move(ret);
 }
 
 //////////////////////////////////////////////////////////////////////////////////////////

diff --git a/dom/canvas/WebGLTextureUpload.cpp b/dom/canvas/WebGLTextureUpload.cpp
@@ -227,7 +227,7 @@ FromImageBitmap(WebGLContext* webgl, const char* funcName, TexImageTarget target
                 uint32_t width, uint32_t height, uint32_t depth,
                 const dom::ImageBitmap& imageBitmap)
 {
-    UniquePtr<dom::ImageBitmapCloneData> cloneData = imageBitmap.ToCloneData();
+    UniquePtr<dom::ImageBitmapCloneData> cloneData = std::move(imageBitmap.ToCloneData());
     if (!cloneData) {
       return nullptr;
     }
@@ -460,7 +460,7 @@ ValidateTexOrSubImage(WebGLContext* webgl, const char* funcName, TexImageTarget
     if (!blob || !blob->Validate(webgl, funcName, pi))
         return nullptr;
 
-    return blob;
+    return std::move(blob);
 }
 
 void

diff --git a/dom/clients/manager/ClientHandle.cpp b/dom/clients/manager/ClientHandle.cpp
@@ -203,7 +203,7 @@ ClientHandle::OnDetach()
   }
 
   RefPtr<GenericPromise> ref(mDetachPromise);
-  return ref;
+  return std::move(ref);
 }
 
 } // namespace dom

diff --git a/dom/clients/manager/ClientInfo.cpp b/dom/clients/manager/ClientInfo.cpp
@@ -145,7 +145,7 @@ ClientInfo::GetPrincipal() const
 {
   MOZ_ASSERT(NS_IsMainThread());
   nsCOMPtr<nsIPrincipal> ref = PrincipalInfoToPrincipal(PrincipalInfo());
-  return ref;
+  return std::move(ref);
 }
 
 } // namespace dom

diff --git a/dom/clients/manager/ClientManager.cpp b/dom/clients/manager/ClientManager.cpp
@@ -136,20 +136,20 @@ ClientManager::CreateSourceInternal(ClientType aType,
     ClientSourceConstructorArgs args(id, aType, aPrincipal, TimeStamp::Now());
     UniquePtr<ClientSource> source(new ClientSource(this, aEventTarget, args));
     source->Shutdown();
-    return source;
+    return std::move(source);
   }
 
   ClientSourceConstructorArgs args(id, aType, aPrincipal, TimeStamp::Now());
   UniquePtr<ClientSource> source(new ClientSource(this, aEventTarget, args));
 
   if (IsShutdown()) {
     source->Shutdown();
-    return source;
+    return std::move(source);
   }
 
   source->Activate(GetActor());
 
-  return source;
+  return std::move(source);
 }
 
 already_AddRefed<ClientHandle>

diff --git a/dom/clients/manager/ClientManagerService.cpp b/dom/clients/manager/ClientManagerService.cpp
@@ -438,8 +438,8 @@ ClientManagerService::MatchAll(const ClientMatchAllArgs& aArgs)
     }
 
     promiseList->AddPromise(
-      source->StartOp(ClientGetInfoAndStateArgs(source->Info().Id(),
-                                                source->Info().PrincipalInfo())));
+      source->StartOp(std::move(ClientGetInfoAndStateArgs(source->Info().Id(),
+                                                     source->Info().PrincipalInfo()))));
   }
 
   // Maybe finish the promise now in case we didn't find any matching clients.

diff --git a/dom/console/Console.cpp b/dom/console/Console.cpp
@@ -2887,8 +2887,8 @@ Console::MonotonicTimer(JSContext* aCx, MethodName aMethodName,
         return false;
       }
 
-      timelines->AddMarkerForDocShell(docShell,
-        MakeUnique<TimestampTimelineMarker>(key));
+      timelines->AddMarkerForDocShell(docShell, std::move(
+        MakeUnique<TimestampTimelineMarker>(key)));
     }
     // For `console.time(foo)` and `console.timeEnd(foo)`.
     else if (isTimelineRecording && aData.Length() == 1) {
@@ -2903,10 +2903,10 @@ Console::MonotonicTimer(JSContext* aCx, MethodName aMethodName,
         return false;
       }
 
-      timelines->AddMarkerForDocShell(docShell,
+      timelines->AddMarkerForDocShell(docShell, std::move(
         MakeUnique<ConsoleTimelineMarker>(
           key, aMethodName == MethodTime ? MarkerTracingType::START
-                                         : MarkerTracingType::END));
+                                         : MarkerTracingType::END)));
     }
 
     return true;

diff --git a/dom/events/EventListenerManager.cpp b/dom/events/EventListenerManager.cpp
@@ -1245,9 +1245,9 @@ EventListenerManager::HandleEventInternal(nsPresContext* aPresContext,
                   nsAutoString typeStr;
                   (*aDOMEvent)->GetType(typeStr);
                   uint16_t phase = (*aDOMEvent)->EventPhase();
-                  timelines->AddMarkerForDocShell(docShell,
+                  timelines->AddMarkerForDocShell(docShell, std::move(
                     MakeUnique<EventTimelineMarker>(
-                      typeStr, phase, MarkerTracingType::START));
+                      typeStr, phase, MarkerTracingType::START)));
                 }
               }
             }

diff --git a/dom/file/uri/BlobURLProtocolHandler.cpp b/dom/file/uri/BlobURLProtocolHandler.cpp
@@ -546,7 +546,7 @@ class ReleasingTimerHolder final : public Runnable
     nsresult rv = svc->GetXpcomWillShutdown(getter_AddRefs(phase));
     NS_ENSURE_SUCCESS(rv, nullptr);
 
-    return phase;
+    return std::move(phase);
   }
 
   nsCString mURI;

diff --git a/dom/geolocation/nsGeolocation.cpp b/dom/geolocation/nsGeolocation.cpp
@@ -1164,7 +1164,7 @@ Geolocation::GetCurrentPosition(PositionCallback& aCallback,
 {
   nsresult rv = GetCurrentPosition(GeoPositionCallback(&aCallback),
                                    GeoPositionErrorCallback(aErrorCallback),
-                                   CreatePositionOptionsCopy(aOptions),
+                                   std::move(CreatePositionOptionsCopy(aOptions)),
                                    aCallerType);
 
   if (NS_FAILED(rv)) {
@@ -1242,7 +1242,7 @@ Geolocation::WatchPosition(PositionCallback& aCallback,
   int32_t ret = 0;
   nsresult rv = WatchPosition(GeoPositionCallback(&aCallback),
                               GeoPositionErrorCallback(aErrorCallback),
-                              CreatePositionOptionsCopy(aOptions),
+                              std::move(CreatePositionOptionsCopy(aOptions)),
                               aCallerType,
                               &ret);