Bug 1505574 - Unhook Unboxed Objects option and disable by default r=…

…iain Differential Revision: https://phabricator.services.mozilla.com/D24036 --HG-- extra : moz-landing-system : lando
trman · Mar 22, 2019 · b31262c · b31262c
1 parent 559632b
commit b31262c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 8 deletions.
diff --git a/js/src/jit/JitOptions.cpp b/js/src/jit/JitOptions.cpp
@@ -248,7 +248,7 @@ DefaultJitOptions::DefaultJitOptions() {
 #endif
 
   // Toggles whether unboxed plain objects can be created by the VM.
-  SET_DEFAULT(disableUnboxedObjects, false);
+  SET_DEFAULT(disableUnboxedObjects, true);
 
   // Toggles the optimization whereby offsets are folded into loads and not
   // included in the bounds check.

diff --git a/js/src/jsapi.cpp b/js/src/jsapi.cpp
@@ -5562,9 +5562,6 @@ JS_PUBLIC_API void JS_SetGlobalJitCompilerOption(JSContext* cx,
     case JSJITCOMPILER_TRACK_OPTIMIZATIONS:
       jit::JitOptions.disableOptimizationTracking = !value;
       break;
-    case JSJITCOMPILER_UNBOXED_OBJECTS:
-      jit::JitOptions.disableUnboxedObjects = !value;
-      break;
     case JSJITCOMPILER_SPECTRE_INDEX_MASKING:
       jit::JitOptions.spectreIndexMasking = !!value;
       break;

diff --git a/js/src/shell/js.cpp b/js/src/shell/js.cpp
@@ -10208,10 +10208,6 @@ static bool SetContextOptions(JSContext* cx, const OptionParser& op) {
       .setNativeRegExp(enableNativeRegExp)
       .setAsyncStack(enableAsyncStacks);
 
-  if (op.getBoolOption("no-unboxed-objects")) {
-    jit::JitOptions.disableUnboxedObjects = true;
-  }
-
   if (const char* str = op.getStringOption("cache-ir-stubs")) {
     if (strcmp(str, "on") == 0) {
       jit::JitOptions.disableCacheIR = false;