Skip to content

Commit

Permalink
Bug 1586599 part 1 - Fix type barrier in IonBuilder::jsop_getimport. …
Browse files Browse the repository at this point in the history
…r=jonco,tcampbell a=lizzard

Differential Revision: https://phabricator.services.mozilla.com/D49419

--HG--
extra : source : b0305f4f131792ce5aaa902b39622a6875acd1d4
extra : intermediate-source : d6e38dc122e6f73d42db74c10047367b9c9416f2
  • Loading branch information
jandem committed Oct 16, 2019
1 parent 16b9aac commit ed4722e
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions js/src/jit/IonBuilder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8390,12 +8390,8 @@ AbortReasonOr<Ok> IonBuilder::jsop_getimport(PropertyName* name) {
ModuleEnvironmentObject* targetEnv;
MOZ_ALWAYS_TRUE(env->lookupImport(NameToId(name), &targetEnv, &shape));

TypeSet::ObjectKey* staticKey = TypeSet::ObjectKey::get(targetEnv);
TemporaryTypeSet* types = bytecodeTypes(pc);
BarrierKind barrier = PropertyReadNeedsTypeBarrier(
analysisContext, alloc(), constraints(), staticKey, name, types,
/* updateObserved = */ true);

BarrierKind barrier = BarrierKind::TypeSet;
MOZ_TRY(loadStaticSlot(targetEnv, barrier, types, shape->slot()));

// In the rare case where this import hasn't been initialized already (we
Expand Down

0 comments on commit ed4722e

Please sign in to comment.