Skip to content

Commit

Permalink
Spellcheck (dotnet#2085)
Browse files Browse the repository at this point in the history 
I ran https://github.com/EWSoftware/VSSpellChecker on the solution.

This is mostly just comment fixes in the unit tests, but the XSD changes might have an affect on the translations.

* Typo: Dependency

* Typo: Assemblies

* Typo: Doesn't

* Typo: Same

* Typo: Duplicate "the"

* Typo: Duplicate word "char"

* Typo: After

* Typo: Duplicate word "as"

* Typo: Because

* Typo: Chaining

* Typo: characters

* Typo: Duplicate word "Append"

* Typo: architecture

* Typo: assembly

* Typo: Because

* Typo: Buckets

* Typo: canonical

* Typo: choosing

* Typo: class name

* Typo: crash

* Typo: delimited

* Typo: dependent

* Typo: disabled

* Typo: deterministic

* Typo: escaped

* Typo: Event

* Typo: framework

* Typo: Duplicate word "the"

* Typo: Duplicate word "that"

* Typo: third

* Typo: The

* Typo: Throw

* Typo: through

* Typo: transformation

* Typo: invalid

* Typo: initialize

* Typo: Included

* Typo: Initialize

* Typo: implementation

* Typo: writable

* Typo: with

* Typo: wherever

* Typo: Duplicate word "when"

* Typo: warnings

* Typo: when

* Typo: versions

* Typo: Duplicate word "type"

* Typo: Duplicate word "three"

* Typo: delegate

* Typo: exception

* Typo: existence

* Typo: existent

* Typo: explicitly

* Typo: extension

* Typo: fictitious

* Typo: Duplicate word "for"

* Typo: generated

* Typo: going

* Typo: if

* Typo: Duplicate word "in"

* Typo: interpreted

* Typo: interpret

* Typo: Duplicate word "is"

* Typo: initialized

* Typo: items

* Typo: length

* Typo: Make sure

* Typo: manager

* Typo: manifest

* Typo: metadata

* Typo: mechanism

* Typo: Message

* Typo: metadata

* Typo: mutually

* Typo: Duplicate word "no"

* Typo: nonexistent

* Typo: nothing

* Typo: not

* Typo: occurring

* Typo: output

* Typo: outstanding

* Typo: overridden

* Typo: parameters

* Typo: project

* Typo: properties

* Typo: propagates

* Typo: reference

* Typo: regular

* Typo: be relative

* Typo: Separate

* Typo: Duplicate word "should"

* Typo: Should not

* Typo: signaled

* Typo: solvable

* Typo: specified

* Typo: specific

* Typo: succeed

* Typo: successfully

* Typo: during

* Typo: default targets

* Typo: doesn't

* Typo: Don't

* Typo: during

* Typo: equivalence

* Typo: figuring

* Typo: handle

* Typo: Duplicate word "has"

* Typo: irrelevant

* Typo: Duplicate word "many"

* Typo: nothing

* Typo: processed

* Typo: chain

* Typo: nonexistent

* Typo: qualifiers

* Typo: result is

* Typo: Returns

* Typo: success

* Typo: than
  • Loading branch information
@nschonni @rainersigwald
nschonni authored and rainersigwald committed May 10, 2017
1 parent 8da2820 commit 8411705
Show file tree
Hide file tree
Showing 88 changed files with 1,156 additions and 1,157 deletions.
2 changes: 1 addition & 1 deletion NuGet.Config
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<packageRestore>
<add key="enabled" value="True" />
</packageRestore>
<!-- The commented out feeds were failing on non windows restore. Restore seems to finish succsesfully without them.
<!-- The commented out feeds were failing on non windows restore. Restore seems to finish successfully without them.
Should be removed if restore does not regress-->
<packageSources>
<clear />
Expand Down
8 changes: 4 additions & 4 deletions Samples/Dependency/Properties/AssemblyInfo.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;

// General Information about an assembly is controlled through the following
// General Information about an assembly is controlled through the following
// set of attributes. Change these attribute values to modify the information
// associated with an assembly.
[assembly: AssemblyTitle("Dependency")]
[assembly: AssemblyDescription("")]
[assembly: AssemblyConfiguration("")]
[assembly: AssemblyCompany("")]
[assembly: AssemblyProduct("Depedency")]
[assembly: AssemblyProduct("Dependency")]
[assembly: AssemblyCopyright("Copyright \u00A9 2015")]
[assembly: AssemblyTrademark("")]
[assembly: AssemblyCulture("")]
Expand All @@ -22,11 +22,11 @@
// Version information for an assembly consists of the following four values:
//
// Major Version
// Minor Version
// Minor Version
// Build Number
// Revision
//
// You can specify all the values or you can default the Build and Revision Numbers
// You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")]
Expand Down
4 changes: 2 additions & 2 deletions src/Build.OM.UnitTests/Construction/ConstructionEditing_Tests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,7 @@ public void AddItemWithRemoveToItemGroupInTarget()

Helpers.VerifyAssertProjectContent(expected, project);
}

/// <summary>
/// Add item with remove in itemgroup in target
/// </summary>
Expand Down Expand Up @@ -1905,7 +1905,7 @@ public void AddItem_ExistingItemGroupWithDifferentItemType()
/// Add an item to a project with a single item group with existing items of
/// various item types and item specs; should add in alpha order of item type,
/// then item spec, keeping different item specs in different groups; different
/// item groups are not mutally sorted
/// item groups are not mutually sorted
/// </summary>
[Fact]
public void AddItem_ExistingItemGroupWithVariousItems()
Expand Down
2 changes: 1 addition & 1 deletion src/Build.OM.UnitTests/Construction/ProjectImportGroupElement_Tests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public void ReadNoChild()
}

/// <summary>
/// Read import group with a contained import that has no no project attribute
/// Read import group with a contained import that has no project attribute
/// </summary>
[Fact]
public void ReadInvalidChildMissingProject()
Expand Down
10 changes: 5 additions & 5 deletions src/Build.OM.UnitTests/Construction/ProjectRootElement_Tests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ namespace Microsoft.Build.UnitTests.OM.Construction
/// </summary>
public class ProjectRootElement_Tests
{
private const string SimpleProject =
private const string SimpleProject =
@"<Project xmlns=`msbuildnamespace`>
<PropertyGroup>
Expand Down Expand Up @@ -104,7 +104,7 @@ public void EmptyProject()
}

/// <summary>
/// Set defaulttargets
/// Set default targets
/// </summary>
[Fact]
public void SetDefaultTargets()
Expand Down Expand Up @@ -745,7 +745,7 @@ public void EncodingGetterBasedOnActualEncodingWhenXmlDeclarationIsAbsent()
VerifyLoadedProjectHasEncoding(projectFullPath, Encoding.Unicode);

// We don't test ASCII, since there is no byte order mark for it,
// and the XmlReader will legitimately decide to intrepret it as UTF8,
// and the XmlReader will legitimately decide to interpret it as UTF8,
// which would fail the test although it's a reasonable assumption
// when no xml declaration is present.
////VerifyLoadedProjectHasEncoding(projectFullPath, Encoding.ASCII);
Expand Down Expand Up @@ -1331,7 +1331,7 @@ public void TryOpenWithPreserveFormatting()
Assert.False(xml2.PreserveFormatting);

Assert.NotNull(xml0);

Assert.Same(xml0, xml1);
Assert.Same(xml0, xml2);
}
Expand Down Expand Up @@ -1870,7 +1870,7 @@ private void SaveProjectWithEncoding(string projectFullPath, Encoding encoding)
}

/// <summary>
/// Creates a project at a given path with a given encoding but without the Xml declaration,
/// Creates a project at a given path with a given encoding but without the Xml declaration,
/// and then verifies that when loaded by MSBuild, the encoding is correctly reported.
/// </summary>
private void VerifyLoadedProjectHasEncoding(string projectFullPath, Encoding encoding)
Expand Down
4 changes: 2 additions & 2 deletions src/Build.OM.UnitTests/Construction/UsingTaskParameterElement_Tests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public void SetRequired()
}

/// <summary>
/// Set type type to empty
/// Set type to empty
/// </summary>
[Fact]
public void SetEmptyType()
Expand Down Expand Up @@ -186,7 +186,7 @@ public void SetEmptyRequired()
}

/// <summary>
/// Set type type to null
/// Set type to null
/// </summary>
[Fact]
public void SetNullType()
Expand Down
56 changes: 28 additions & 28 deletions src/Build.OM.UnitTests/Definition/DefinitionEditing_Tests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public static IEnumerable<object[]> ItemElementsThatRequireSplitting
</ItemGroup>
</Project>",
0, // operate on first item
null // project setup that should be performed afte the project is loaded. Used to simulate items coming from globs
null // project setup that should be performed after the project is loaded. Used to simulate items coming from globs
};
// explode on item coming from property with one item
yield return new object[]
Expand Down Expand Up @@ -77,7 +77,7 @@ public static IEnumerable<object[]> ItemElementsThatRequireSplitting
0,
null
};
// explode on item coming from item refence with one item
// explode on item coming from item reference with one item
yield return new object[]
{
@"<Project ToolsVersion=""msbuilddefaulttoolsversion"" xmlns=""msbuildnamespace"">
Expand All @@ -91,7 +91,7 @@ public static IEnumerable<object[]> ItemElementsThatRequireSplitting
1, // operate on the second item. It is produced by the second item element
null
};
// explode on item coming from item refence with multiple items
// explode on item coming from item reference with multiple items
yield return new object[]
{
@"<Project ToolsVersion=""msbuilddefaulttoolsversion"" xmlns=""msbuildnamespace"">
Expand Down Expand Up @@ -261,8 +261,8 @@ public void AddItem_NullMetadata()
}

/// <summary>
/// Add an item whose include has a property expression. As a convenience, we attempt to expand the
/// expression to create the evaluated include.
/// Add an item whose include has a property expression. As a convenience, we attempt to expand the
/// expression to create the evaluated include.
/// </summary>
[Fact]
public void AddItem_IncludeContainsPropertyExpression()
Expand All @@ -278,7 +278,7 @@ public void AddItem_IncludeContainsPropertyExpression()
}

/// <summary>
/// Add an item whose include has a wildcard. We attempt to expand the wildcard using the
/// Add an item whose include has a wildcard. We attempt to expand the wildcard using the
/// file system. In this case, we have one entry in the project and two evaluated items.
/// </summary>
[Fact]
Expand Down Expand Up @@ -316,8 +316,8 @@ public void AddItem_IncludeContainsWildcard()
}

/// <summary>
/// Add an item whose include has an item expression. As a convenience, we attempt to expand the
/// expression to create the evaluated include.
/// Add an item whose include has an item expression. As a convenience, we attempt to expand the
/// expression to create the evaluated include.
/// This value will not be reliable until the project is reevaluated --
/// for example, it assumes any items referenced are defined above this one.
/// </summary>
Expand Down Expand Up @@ -592,7 +592,7 @@ public void AddItem_DoesntMatchComplicatedWildcard()
/// that matches that wildcard. In this case, we add a new item, because the old
/// one wasn't equivalent.
/// In contrast Orcas/Whidbey assumed that the user wants
/// that metadata on the new item, too.
/// that metadata on the new item, too.
/// </summary>
[Fact]
public void AddItem_DoesNotMatchWildcardWithMetadata()
Expand Down Expand Up @@ -647,7 +647,7 @@ public void AddItemWithMetadata_DoesNotMatchWildcardWithNoMetadata()

/// <summary>
/// There's a wildcard in the project already, but it's part of a semicolon-separated
/// list of items. Now the user tries to add an item that matches that wildcard.
/// list of items. Now the user tries to add an item that matches that wildcard.
/// In this case, we don't touch the project at all.
/// </summary>
[Fact]
Expand Down Expand Up @@ -834,7 +834,7 @@ public void RemoveMetadata_ItemOriginatingWithWildcard()

/// <summary>
/// There's a wildcard in the project already, but it's part of a semicolon-separated
/// list of items, and it uses a property reference. Now the user tries to add a new
/// list of items, and it uses a property reference. Now the user tries to add a new
/// item that matches that wildcard. In this case, we don't touch the project at all.
/// </summary>
[Fact]
Expand Down Expand Up @@ -971,11 +971,11 @@ public void RenameItem_NewNameContainsItemExpressionExpandingToTwoItems()
/// Rename, with the new name containing an item expression.
/// Because the new name expands to not exactly one item, we don't attempt to
/// update the evaluated include.
/// Reasoning: The case we interested in for expansion here is setting something
/// like "$(sourcesroot)\foo.cs" and expanding that to a single item.
/// If say "@(foo)" is set as the new name, and it expands to blank, that might
/// be surprising to the host and maybe even unhandled, if on full reevaluation
/// it wouldn't expand to blank. That's why I'm being cautious and supporting
/// Reasoning: The case we interested in for expansion here is setting something
/// like "$(sourcesroot)\foo.cs" and expanding that to a single item.
/// If say "@(foo)" is set as the new name, and it expands to blank, that might
/// be surprising to the host and maybe even unhandled, if on full reevaluation
/// it wouldn't expand to blank. That's why I'm being cautious and supporting
/// the most common scenario only. Many hosts will do a ReevaluateIfNecessary before reading anyway (including CPS)
/// </summary>
[Fact]
Expand Down Expand Up @@ -1465,7 +1465,7 @@ public void RemoveItemThrowsWhenItemElementSplittingIsDisabled(string projectCon
{
AssertDisabledItemSplitting(projectContents, itemIndex, setupProject, (p, i) => { p.RemoveItem(i); });
}

[Theory]
[MemberData(nameof(ItemElementsThatRequireSplitting))]
[MemberData(nameof(ItemElementsWithGlobsThatRequireSplitting))]
Expand Down Expand Up @@ -1560,7 +1560,7 @@ public void SetPropertyWithPropertyExpression()
/// <summary>
/// Verify item expressions are not expanded in new property values.
/// NOTE: They aren't expanded to "blank". It just seems like that, because
/// when you output them, item expansion happens after property expansion, and
/// when you output them, item expansion happens after property expansion, and
/// they may evaluate to blank then. (Unless items do exist at that point.)
/// </summary>
[Fact]
Expand Down Expand Up @@ -2009,7 +2009,7 @@ public void AddItem_ExpandsToSeveralWithMetadata()
}

/// <summary>
/// Add metadata that would be modified by evaluation.
/// Add metadata that would be modified by evaluation.
/// Should be evaluated on a best-effort basis.
/// </summary>
[Fact]
Expand Down Expand Up @@ -2200,8 +2200,8 @@ public void AddItemFast_NullMetadata()
}

/// <summary>
/// Add an item whose include has a property expression. As a convenience, we attempt to expand the
/// expression to create the evaluated include.
/// Add an item whose include has a property expression. As a convenience, we attempt to expand the
/// expression to create the evaluated include.
/// </summary>
[Fact]
public void AddItemFast_IncludeContainsPropertyExpression()
Expand All @@ -2217,7 +2217,7 @@ public void AddItemFast_IncludeContainsPropertyExpression()
}

/// <summary>
/// Add an item whose include has a wildcard. We attempt to expand the wildcard using the
/// Add an item whose include has a wildcard. We attempt to expand the wildcard using the
/// file system. In this case, we have one entry in the project and two evaluated items.
/// </summary>
[Fact]
Expand Down Expand Up @@ -2255,8 +2255,8 @@ public void AddItemFast_IncludeContainsWildcard()
}

/// <summary>
/// Add an item whose include has an item expression. As a convenience, we attempt to expand the
/// expression to create the evaluated include.
/// Add an item whose include has an item expression. As a convenience, we attempt to expand the
/// expression to create the evaluated include.
/// This value will not be reliable until the project is reevaluated --
/// for example, it assumes any items referenced are defined above this one.
/// </summary>
Expand Down Expand Up @@ -2524,7 +2524,7 @@ public void AddItemFast_DoesntMatchComplicatedWildcard()
/// that matches that wildcard. In this case, we add a new item, because the old
/// one wasn't equivalent.
/// In contrast Orcas/Whidbey assumed that the user wants
/// that metadata on the new item, too.
/// that metadata on the new item, too.
/// </summary>
[Fact]
public void AddItemFast_DoesNotMatchWildcardWithMetadata()
Expand Down Expand Up @@ -2579,7 +2579,7 @@ public void AddItemFastWithMetadata_DoesNotMatchWildcardWithNoMetadata()

/// <summary>
/// There's a wildcard in the project already, but it's part of a semicolon-separated
/// list of items. Now the user tries to add an item that matches that wildcard.
/// list of items. Now the user tries to add an item that matches that wildcard.
/// In this case, we don't touch the project at all.
/// </summary>
[Fact]
Expand Down Expand Up @@ -2626,12 +2626,12 @@ private static void AssertDisabledItemSplitting(string projectContents, int item
}

project.ThrowInsteadOfSplittingItemElement = true;

var initialXml = project.Xml.RawXml;
var item = project.Items.ElementAt(itemIndex);

var ex = Assert.Throws(typeof(InvalidOperationException), () => itemOperation(project, item));

Assert.Matches("The requested operation needs to split the item element at location .* into individual elements but item element splitting is disabled with .*", ex.Message);
Assert.False(project.IsDirty, "project should not be dirty after item splitting threw exception");
Assert.Equal(initialXml, project.Xml.RawXml);
Expand Down
12 changes: 6 additions & 6 deletions src/Build.OM.UnitTests/Definition/ProjectCollection_Tests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ public void TwoProjectsDistinguishedByGlobalPropertiesOnly()

/// <summary>
/// Validates that we can correctly load two of the same project file with different global properties, even when
/// those global properties are applied to the project by the project collection (and then overrided in one case).
/// those global properties are applied to the project by the project collection (and then overridden in one case).
/// </summary>
[Fact]
public void TwoProjectsDistinguishedByGlobalPropertiesOnly_ProjectOverridesProjectCollection()
Expand Down Expand Up @@ -562,7 +562,7 @@ public void ChangingGlobalPropertiesUpdatesCollection()
}

/// <summary>
/// Changing global properties on collection should should update the collection's defaults,
/// Changing global properties on collection should update the collection's defaults,
/// and any projects even if they have defined the same global properties
/// </summary>
[Fact]
Expand Down Expand Up @@ -591,7 +591,7 @@ public void SettingGlobalPropertiesOnCollectionUpdatesProjects()
}

/// <summary>
/// Changing global properties on collection should should update the collection's defaults,
/// Changing global properties on collection should update the collection's defaults,
/// and any projects even if they have defined the same global properties
/// </summary>
[Fact]
Expand All @@ -613,7 +613,7 @@ public void SettingGlobalPropertiesOnCollectionUpdatesProjects2()
}

/// <summary>
/// Changing global properties on collection should should update the collection's defaults,
/// Changing global properties on collection should update the collection's defaults,
/// and all projects as well
/// </summary>
[Fact]
Expand Down Expand Up @@ -660,7 +660,7 @@ public void RemovingGlobalPropertiesOnCollectionUpdatesProjects()
}

/// <summary>
/// Changing global properties on collection should should update the collection's defaults,
/// Changing global properties on collection should update the collection's defaults,
/// and all projects as well
/// </summary>
[Fact]
Expand Down Expand Up @@ -1357,7 +1357,7 @@ public void ProjectXmlChangedEvent()
collection.SetGlobalProperty("a", "b");
Assert.False(dirtyRaised);

// Change GlobalProperties on a project to see that that doesn't propagate as an XML change.
// Change GlobalProperties on a project to see that doesn't propagate as an XML change.
dirtyRaised = false;
var project = new Project(pre);
project.SetGlobalProperty("q", "s");
Expand Down
Loading

0 comments on commit 8411705

Please sign in to comment.