Replace deprecated tempdir dependency with tempfile (openethereum#11588)

`Tempdir` is deprecated, but the functionality has been merged into
another crate: `tempfile`. This commit removes all `tempdir` dependencies
and replaces them with `tempfile` and the equivalent bindings.

Fixes openethereum#11560

Cargo.toml

@@ -86,7 +86,7 @@ rustc_version = "0.2"
 [dev-dependencies]
 pretty_assertions = "0.1"
 ipnetwork = "0.12.6"
-tempdir = "0.3"
+tempfile = "3.1"
 fake-fetch = { path = "util/fake-fetch" }
 
 [target.'cfg(windows)'.dependencies]

accounts/Cargo.toml

@@ -18,4 +18,4 @@ serde_json = "1.0"
 
 [dev-dependencies]
 ethereum-types = "0.8.0"
-tempdir = "0.3"
+tempfile = "3.1"

accounts/ethstore/Cargo.toml

@@ -22,7 +22,7 @@ ethereum-types = "0.8.0"
 dir = { path = "../../util/dir" }
 smallvec = "1.2.0"
 parity-wordlist = "1.3.1"
-tempdir = "0.3"
+tempfile = "3.1"
 
 [dev-dependencies]
 matches = "0.1"

accounts/ethstore/cli/Cargo.toml

@@ -24,4 +24,4 @@ path = "src/main.rs"
 doc = false
 
 [dev-dependencies]
-tempdir = "0.3"
+tempfile = "3.1"

accounts/ethstore/cli/tests/cli.rs

@@ -14,9 +14,9 @@
 // You should have received a copy of the GNU General Public License
 // along with Open Ethereum.  If not, see <http://www.gnu.org/licenses/>.
 
-extern crate tempdir;
+extern crate tempfile;
 use std::process::Command;
-use tempdir::TempDir;
+use tempfile::Builder;
 use std::fs::File;
 use std::io::Write;
 
@@ -37,7 +37,7 @@ fn cli_cmd() {
 		.output()
 		.unwrap();
 
-	let dir = TempDir::new("test-vault").unwrap();
+	let dir = Builder::new().prefix("test-vault").tempdir().unwrap();
 
 	let mut passwd = File::create(dir.path().join("test-password")).unwrap();
 	writeln!(passwd, "password").unwrap();

accounts/ethstore/src/accounts_dir/disk.rs

@@ -351,13 +351,13 @@ fn account_filename(account: &SafeAccount) -> String {
 
 #[cfg(test)]
 mod test {
-	extern crate tempdir;
+	extern crate tempfile;
 
 	use std::{env, fs};
 	use super::{KeyDirectory, RootDiskDirectory, VaultKey};
 	use account::SafeAccount;
 	use crypto::publickey::{Random, Generator};
-	use self::tempdir::TempDir;
+	use self::tempfile::TempDir;
 
 	#[test]
 	fn should_create_new_account() {
@@ -448,7 +448,7 @@ mod test {
 	#[test]
 	fn should_list_vaults() {
 		// given
-		let temp_path = TempDir::new("").unwrap();
+		let temp_path = TempDir::new().unwrap();
 		let directory = RootDiskDirectory::create(&temp_path).unwrap();
 		let vault_provider = directory.as_vault_provider().unwrap();
 		vault_provider.create("vault1", VaultKey::new(&"password1".into(), 1)).unwrap();
@@ -463,7 +463,7 @@ mod test {
 
 	#[test]
 	fn hash_of_files() {
-		let temp_path = TempDir::new("").unwrap();
+		let temp_path = TempDir::new().unwrap();
 		let directory = RootDiskDirectory::create(&temp_path).unwrap();
 
 		let hash = directory.files_hash().expect("Files hash should be calculated ok");

accounts/ethstore/src/accounts_dir/vault.rs

@@ -278,14 +278,14 @@ fn read_vault_file<P>(vault_dir_path: P, key: Option<&VaultKey>) -> Result<Strin
 
 #[cfg(test)]
 mod test {
-	extern crate tempdir;
+	extern crate tempfile;
 
 	use std::fs;
 	use std::io::Write;
 	use std::path::PathBuf;
 	use super::VaultKey;
 	use super::{VAULT_FILE_NAME, check_vault_name, make_vault_dir_path, create_vault_file, read_vault_file, VaultDiskDirectory};
-	use self::tempdir::TempDir;
+	use self::tempfile::TempDir;
 
 	#[test]
 	fn check_vault_name_succeeds() {
@@ -324,7 +324,7 @@ mod test {
 	#[test]
 	fn create_vault_file_succeeds() {
 		// given
-		let temp_path = TempDir::new("").unwrap();
+		let temp_path = TempDir::new().unwrap();
 		let key = VaultKey::new(&"password".into(), 1024);
 		let mut vault_dir: PathBuf = temp_path.path().into();
 		vault_dir.push("vault");
@@ -343,7 +343,7 @@ mod test {
 	#[test]
 	fn read_vault_file_succeeds() {
 		// given
-		let temp_path = TempDir::new("").unwrap();
+		let temp_path = TempDir::new().unwrap();
 		let key = VaultKey::new(&"password".into(), 1024);
 		let vault_file_contents = r#"{"crypto":{"cipher":"aes-128-ctr","cipherparams":{"iv":"758696c8dc6378ab9b25bb42790da2f5"},"ciphertext":"54eb50683717d41caaeb12ea969f2c159daada5907383f26f327606a37dc7168","kdf":"pbkdf2","kdfparams":{"c":1024,"dklen":32,"prf":"hmac-sha256","salt":"3c320fa566a1a7963ac8df68a19548d27c8f40bf92ef87c84594dcd5bbc402b6"},"mac":"9e5c2314c2a0781962db85611417c614bd6756666b6b1e93840f5b6ed895f003"}}"#;
 		let dir: PathBuf = temp_path.path().into();
@@ -364,7 +364,7 @@ mod test {
 	#[test]
 	fn read_vault_file_fails() {
 		// given
-		let temp_path = TempDir::new("").unwrap();
+		let temp_path = TempDir::new().unwrap();
 		let key = VaultKey::new(&"password1".into(), 1024);
 		let dir: PathBuf = temp_path.path().into();
 		let mut vault_file_path: PathBuf = dir.clone();
@@ -393,7 +393,7 @@ mod test {
 	#[test]
 	fn vault_directory_can_be_created() {
 		// given
-		let temp_path = TempDir::new("").unwrap();
+		let temp_path = TempDir::new().unwrap();
 		let key = VaultKey::new(&"password".into(), 1024);
 		let dir: PathBuf = temp_path.path().into();
 
@@ -413,7 +413,7 @@ mod test {
 	#[test]
 	fn vault_directory_cannot_be_created_if_already_exists() {
 		// given
-		let temp_path = TempDir::new("").unwrap();
+		let temp_path = TempDir::new().unwrap();
 		let key = VaultKey::new(&"password".into(), 1024);
 		let dir: PathBuf = temp_path.path().into();
 		let mut vault_dir = dir.clone();
@@ -430,7 +430,7 @@ mod test {
 	#[test]
 	fn vault_directory_cannot_be_opened_if_not_exists() {
 		// given
-		let temp_path = TempDir::new("").unwrap();
+		let temp_path = TempDir::new().unwrap();
 		let key = VaultKey::new(&"password".into(), 1024);
 		let dir: PathBuf = temp_path.path().into();