✨ Localization & Image Asset Naming Consistency Improvements #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Localizable.xcstrings
.image_name
fields and asset names to ensure consistency between Website Package and MyLibrary Package.Localizable.xcstrings
from different targets.Image Asset Naming Consistency
Previously, Speakers and Organizers had different naming conventions for their images across different packages:
.imageset
name.To prevent potential issues caused by this inconsistency, all image file names and
.imageset
names have been unified.Localizable.xcstrings
Access in Website PackageSince Website Package needs to access
Localizable.xcstrings
in different targets, it must do so through their respective bundles.To achieve this, those targets need to be added as dependencies of Website Package.
macOS Compatibility Changes
To add ScheduleFeature Target as a dependency of Website Package, it must be buildable in a macOS environment.
Dependency Update
The following diagram illustrates the dependency structure: