Skip to content

Commit

Permalink
Addressing RFC8776-bis WG LC comments (#291)
Browse files Browse the repository at this point in the history 
Addressing additional WG LC comments:
- Addressing minor comments from Med not implemented in PR #280 : fix #290 
   - Added an appendix with YANG tree to RFC8776-bis: fix #290 
   - Reordered the acronyms and abbreviations in RFC8776-bis: fix #290 
- Updated bandwidth profile definitions: fix #285
-  Removed te-gen-node-id and moved union within the te-generic-node-id: fix #288 
- Fixed normative references: fix #287
- Clarify why path-computation-error-reason has not been defined in an IANA-maintained model: fix #281 
- Added formats for the MPLS-TE path bandwidth: fix #284
  • Loading branch information
@italobusi
italobusi authored Sep 27, 2024
1 parent 5299bd4 commit 706deee
Show file tree
Hide file tree
Showing 17 changed files with 7,725 additions and 5,167 deletions.
1 change: 1 addition & 0 deletions .gitignore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ rsvp_te_model.tree.save
drafts/te-topo-profile/.refcache/*.*
drafts/mpls-te-topology/.refcache/*.*
drafts/te-types-update/.refcache/*.*
drafts/te-types-update/diffs/*.*
172 changes: 122 additions & 50 deletions drafts/te-types-update/diffs/te-pkt-types/model-diff-spaces.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@
< the license terms contained in, the Simplified BSD License set
---
> the license terms contained in, the Revised BSD License set
51,52c65,86
51,52c65,87
< This version of this YANG module is part of RFC 8776; see the
< RFC itself for full legal notices.";
---
> This version of this YANG module is part of RFC XXXX
> (https://www.rfc-editor.org/info/rfcXXXX); see the RFC itself
> for full legal notices.";
> revision 2024-07-23 {
> revision 2024-09-27 {
> description
> "This revision adds the following new identities:
> - bandwidth-profile-type;
Expand All @@ -58,6 +58,7 @@
> - path-metric-loss.
>
> This revision adds the following new groupings:
> - bandwidth-profile-parameters;
> - te-packet-path-bandwidth;
> - te-packet-link-bandwidth.
>
Expand All @@ -67,7 +68,7 @@
> }
> // RFC Editor: replace XXXX with actual RFC number, update date
> // information and remove this note
61c95,201
61c96,202
< /**
---
> /*
Expand Down Expand Up @@ -177,112 +178,124 @@
> }
>
> /*
91c231
67c208,212
< enum specified {
---
> enum specified-value {
> description
> "Bandwidth value is explicitly specified.";
> }
> enum specified-profile {
69c214
< "Bandwidth is explicitly specified.";
---
> "Bandwidth profile is explicitly specified.";
91c236
< MPLS Traffic Engineering";
---
> MPLS Traffic Engineering";
102c242
102c247
< MPLS Traffic Engineering";
---
> MPLS Traffic Engineering";
149c289
149c294
< MPLS Traffic Engineering";
---
> MPLS Traffic Engineering";
177,178c317,318
177,178c322,323
< Constraints Model for Diffserv-aware MPLS Traffic Engineering
< & Performance Comparisons";
---
> Constraints Model for Diffserv-aware MPLS Traffic
> Engineering & Performance Comparisons";
180a321,324
180a326,329
> /*
> * Groupings
> */
>
220c364
220c369
< Statement, Section 4.2";
---
> Statement, Section 4.2";
229c373
229c378
< Extensions
---
> Extensions
231,232c375,376
231,232c380,381
< Explicitly Routed Label Switched Paths (LSPs) Using
< TE Metric Extensions
---
> Explicitly Routed Label Switched Paths (LSPs)
> Using TE Metric Extensions
234c378
234c383
< Extensions";
---
> Extensions";
247c391
247c396
< Extensions, Section 4.4";
---
> Extensions, Section 4.4";
256c400
256c405
< Extensions
---
> Extensions
258,259c402,403
258,259c407,408
< Explicitly Routed Label Switched Paths (LSPs) Using
< TE Metric Extensions
---
> Explicitly Routed Label Switched Paths (LSPs)
> Using TE Metric Extensions
261c405
261c410
< Extensions";
---
> Extensions";
283c427
283c432
< Extensions
---
> Extensions
285,286c429,430
285,286c434,435
< Explicitly Routed Label Switched Paths (LSPs) Using
< TE Metric Extensions
---
> Explicitly Routed Label Switched Paths (LSPs)
> Using TE Metric Extensions
288c432
288c437
< Extensions";
---
> Extensions";
305c449
305c454
< Extensions
---
> Extensions
307,308c451,452
307,308c456,457
< Explicitly Routed Label Switched Paths (LSPs) Using
< TE Metric Extensions
---
> Explicitly Routed Label Switched Paths (LSPs)
> Using TE Metric Extensions
310c454
310c459
< Extensions";
---
> Extensions";
321c465
321c470
< Statement, Section 4.2";
---
> Statement, Section 4.2";
330c474
330c479
< Extensions
---
> Extensions
332,333c476,477
332,333c481,482
< Explicitly Routed Label Switched Paths (LSPs) Using
< TE Metric Extensions
---
> Explicitly Routed Label Switched Paths (LSPs)
> Using TE Metric Extensions
335c479
335c484
< Extensions";
---
> Extensions";
358,363c502,508
358,363c507,513
< "RFC 7471: OSPF Traffic Engineering (TE) Metric Extensions
< RFC 7823: Performance-Based Path Selection for
< Explicitly Routed Label Switched Paths (LSPs) Using
Expand All @@ -297,7 +310,7 @@
> Using TE Metric Extensions
> RFC 8570: IS-IS Traffic Engineering (TE) Metric
> Extensions";
407a553,599
407a558,604
> // CHANGE NOTE: The grouping
> // one-way-performance-metrics-gauge-packet has been added in
> // this module revision
Expand Down Expand Up @@ -345,7 +358,7 @@
> }
> }
>
447a640,683
447a645,688
> // CHANGE NOTE: The grouping
> // two-way-performance-metrics-gauge-packet has been added in
> // this module revision
Expand Down Expand Up @@ -390,39 +403,26 @@
> }
> }
>
472a709,780
472a714,844
> }
> }
>
> // CHANGE NOTE: The te-packet-path-bandwidth below has been
> // CHANGE NOTE: The bandwidth-profile-parameters below has been
> // added in this module revision
> // RFC Editor: remove the note above and this note
> grouping te-packet-path-bandwidth {
> grouping bandwidth-profile-parameters {
> description
> "Path bandwidth for Packet. ";
> leaf bandwidth-profile-name {
> type string;
> description
> "Name of Bandwidth Profile.";
> }
> leaf bandwidth-profile-type {
> type identityref {
> base bandwidth-profile-type;
> }
> description
> "Type of Bandwidth Profile.";
> }
> "Common parameters to define bandwidth profiles in packet
> networks.";
> leaf cir {
> type uint64;
> units "bits/second";
> mandatory true;
> description
> "Committed Information Rate (CIR).";
> }
> leaf cbs {
> type uint64;
> units "bits/second";
> mandatory true;
> units "bytes";
> description
> "Committed Burst Size (CBS).";
> }
Expand Down Expand Up @@ -455,11 +455,83 @@
> // CHANGE NOTE: The te-packet-path-bandwidth below has been
> // added in this module revision
> // RFC Editor: remove the note above and this note
> grouping te-packet-path-bandwidth {
> description
> "Bandwidth attributes for TE Packet paths.";
> container packet-bandwidth {
> description
> "Bandwidth attributes for TE Packet paths.";
> leaf specification-type {
> type te-bandwidth-requested-type;
> description
> "The bandwidth specification type, either explicitly
> specified or automatically computed.";
> }
> leaf set-bandwidth {
> when "../specification-type = 'specified-value'" {
> description
> "When the bandwidth value is explicitly specified.";
> }
> type bandwidth-kbps;
> description
> "Set the bandwidth value explicitly, e.g., using offline
> calculation.";
> }
> container bandwidth-profile {
> when "../specification-type = 'specified-profile'" {
> description
> "When the bandwidth profile is explicitly specified.";
> }
> description
> "Set the bandwidth profile attributes explicitly.";
> leaf bandwidth-profile-name {
> type string;
> description
> "Name of Bandwidth Profile.";
> }
> leaf bandwidth-profile-type {
> type identityref {
> base bandwidth-profile-type;
> }
> description
> "Type of Bandwidth Profile.";
> }
> uses bandwidth-profile-parameters;
> }
> leaf class-type {
> type te-types:te-ds-class;
> description
> "The Class-Type of traffic transported by the LSP.";
> reference
> "RFC 4124: Protocol Extensions for Support of
> Diffserv-aware MPLS Traffic Engineering,
> Section 4.3.1";
> }
> leaf signaled-bandwidth {
> type te-packet-types:bandwidth-kbps;
> config false;
> description
> "The currently signaled bandwidth of the LSP.
>
> In the case where the bandwidth is specified
> explicitly, then this will match the value of the
> set-bandwidth leaf.
>
> In the cases where the bandwidth is dynamically
> computed by the system, the current value of the
> bandwidth should be reflected.";
> }
> }
> }
>
> // CHANGE NOTE: The te-packet-path-bandwidth below has been
> // added in this module revision
> // RFC Editor: remove the note above and this note
> grouping te-packet-link-bandwidth {
> description
> "Link Bandwidth for Packet. ";
> "Bandwidth attributes for Packet TE links.";
> leaf packet-bandwidth {
> type uint64;
> units "bits/second";
> description
> "Available bandwith value.";
> "Bandwidth value for Packet TE links.";
Loading

0 comments on commit 706deee

Please sign in to comment.