filter/date: Improvements #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsaikd
reviewed
Oct 18, 2018
| Format: []string{time.RFC3339Nano}, | ||
| Source: "message", | ||
| Target: "@timestamp", | ||
| TagOnFailure: []string{"gogstash_filter_date_error", "_dateparsefailure"}, |
There was a problem hiding this comment.
Why TagOnFailure "_dateparsefailure" as a default value?
I mean there was "gogstash_filter_date_error"
There was a problem hiding this comment.
That was specifically to ensure some sort of compatibility with the output that logstash's date plugin dumps into elasticsearch, so I had added it to the list of tags added on failure to not break compatibility with anything anyone had been doing.
There was a problem hiding this comment.
I think it's better to remove from default value, because not all users migrate from logstash, and it's unnecessary for pure gogstash user.
Write some examples or hints in README for your case?
tsaikd
force-pushed
the
master
branch
6 times, most recently
from
071526d to
71b89d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add'l parameters to add more logstash-like compatibility.