extract() is not our friend (consolidation#903)

and is not fit for static analysis by @phpstan
tsmgeek · Nov 4, 2019 · ca87d26 · ca87d26
1 parent 3fddfaa
commit ca87d26
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/Task/Development/SemVer.php b/src/Task/Development/SemVer.php
@@ -225,8 +225,14 @@ protected function dump()
         if (empty($this->path)) {
             return true;
         }
-        extract($this->version);
-        $semver = sprintf(self::SEMVER, $major, $minor, $patch, $special, $metadata);
+        $semver = sprintf(
+            self::SEMVER,
+            $this->version['major'],
+            $this->version['minor'],
+            $this->version['patch'],
+            $this->version['special'],
+            $this->version['metadata']
+        );
         if (is_writeable($this->path) === false || file_put_contents($this->path, $semver) === false) {
             throw new TaskException($this, 'Failed to write semver file.');
         }