Skip to content

Commit

Permalink
Adding reviewers and review guidelines
Browse files Browse the repository at this point in the history
  • Loading branch information
terafin committed Mar 4, 2020
1 parent 95174b4 commit 7b11651
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 12 deletions.
22 changes: 10 additions & 12 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -174,17 +174,19 @@ CHIP considers there to be a few different types of pull requests:
- Linting passes
- Code style passes

### Review Requirements
Each type of change has unique additional requirements, here's a table of those:

| Type | Reviewer Requirements | New Unit Tests | New Certification Tests | New Fuzz Tests | New Integration Tests |
|----|----|----|----|----|----|
| Trivial bug fix | | | | | |
| Small Bug fix | | | | | | |
| Bug Fix | | | | | | |
| Significiant Change | | | | | | |
| Feature | | | | | | |
| Architecture Change | | | | | | |

| Trivial bug fix | 3 [approved reviewers](./REVIEWERS.md) | | | | |
| Small Bug fix | 3 [approved reviewers](./REVIEWERS.md) | | | | |
| Bug Fix | 3 [approved reviewers](./REVIEWERS.md) | | | | |
| Significiant Change | 3 [approved reviewers](./REVIEWERS.md) | | | | |
| Feature | 3 [approved reviewers](./REVIEWERS.md) | | | | |
| Architecture Change | 3 [approved reviewers](./REVIEWERS.md) | | | | |

Note: Where multiple reviewers are required, each reviewer must be from a different member company.

#### Submit Pull Request

Expand All @@ -194,13 +196,9 @@ button. If you need to make any adjustments to your pull request, just push the
updates to GitHub. Your pull request will automatically track the changes on
your development branch and update.

#### Code reviews

All submissions, including submissions by project members, require 3 reviews to be accepted from different member companies.

#### Merge Requirements

* At least 3 review approvals each from different member companies
* Passes [Review Requirements](#review-requirements)
* [GitHub Workflows](../.github/workflows) pass
* [Certification Tests](tests/certification/README.md) pass
* [Unit Tests](tests/unit/README.md) pass
Expand Down
9 changes: 9 additions & 0 deletions REVIEWERS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
The following individuals can be chosen as, and act as reviewers on any PR

| Name | Company |
|----|----|
| [anush-apple](https://github.com/anush-apple) | Apple, Inc. |
| [chrisdecenzo](https://github.com/chrisdecenzo) | Google, Inc. |
| [hawk248](https://github.com/hawk248) | Comcast, Inc. |
| [gerickson](https://github.com/gerickson) | Google, Inc. |
| [robszewczyk](https://github.com/robszewczyk) | Google, Inc. |

0 comments on commit 7b11651

Please sign in to comment.