Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
dd/cudd_add.pyx
file.Changes to function definitions and error handling:
Cudd_addLeq
fromDdNode*
toint
to reflect its actual return type. (The library did not compile for me without this fix)<
,<=
,>
,>=
) withNotImplementedError
because the implementation does not work with this return type.Enhancements to file type support:
ADD.dump
.Improvements to the
Function
class:value
property to theFunction
class to return the value of a leaf ADD node.Modifications to
_to_dot_recurse
function:taillabel
attributes from edges in the_to_dot_recurse
because it is redundant with the edge style.Remove erroneous shortcut in
find_or_add
:While i was playing around with this library I found out that for an ADD i constructed, the structure was different from the one I created using
PyCUDD
. I traced it down to this erroneous shortcut. I'm guessing you tried to mimic the behaviour of one of the shortcuts that is implemented insideCUDD
, but i think there was a mistake.