Skip to content

Commit

Permalink
remove args from constructor. adds yarn.lock
Browse files Browse the repository at this point in the history
  • Loading branch information
tur-nr committed Mar 27, 2017
1 parent af14eb6 commit 1bd2509
Show file tree
Hide file tree
Showing 5 changed files with 8,216 additions and 9 deletions.
2 changes: 1 addition & 1 deletion dist/polymer-redux.html
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@
return function (parent) {
return class ReduxMixin extends parent {
constructor() {
super(...arguments);
super();

// Collect the action creators first as property changes trigger
// dispatches from observers, see #65, #66, #67
Expand Down
2 changes: 1 addition & 1 deletion lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ function PolymerRedux(store) {
return function (parent) {
return class ReduxMixin extends parent {
constructor() {
super(...arguments);
super();

// Collect the action creators first as property changes trigger
// dispatches from observers, see #65, #66, #67
Expand Down
4 changes: 2 additions & 2 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ export default function PolymerRedux(store) {
* @return {Function} PolymerRedux mixed class.
*/
return parent => class ReduxMixin extends parent {
constructor(...args) {
super(...args);
constructor() {
super();

// Collect the action creators first as property changes trigger
// dispatches from observers, see #65, #66, #67
Expand Down
5 changes: 0 additions & 5 deletions test/polymer-redux.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,6 @@ describe('#PolymerRedux', () => {
});

describe('.constructor()', () => {
it('should call super() w/ args', () => {
new (ReduxMixin(Parent))('foo');
expect(constructor).toHaveBeenCalledWith('foo');
});

it('should subscribe to redux store', () => {
new (ReduxMixin(Parent))();
expect(store.subscribe).toHaveBeenCalled();
Expand Down
Loading

0 comments on commit 1bd2509

Please sign in to comment.