Skip to content

Commit

Permalink
iPad: always have nav bar label text beside icons (keybase#23707)
Browse files Browse the repository at this point in the history
  • Loading branch information
cjb authored Apr 13, 2020
1 parent 1bf7e37 commit 94e047b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions shared/override-d.ts/react-navigation/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1029,6 +1029,7 @@ declare module 'react-navigation' {
tabStyle?: StyleProp<ViewStyle>
indicatorStyle?: StyleProp<ViewStyle>
keyboardHidesTabBar?: boolean
labelPosition?: 'beside-icon' | 'below-icon'
}
swipeEnabled?: boolean
animationEnabled?: boolean
Expand Down
1 change: 1 addition & 0 deletions shared/router-v2/router.native.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ const VanillaTabNavigator = createBottomTabNavigator(
},
// else keyboard avoiding is racy on ios and won't work correctly
keyboardHidesTabBar: Styles.isAndroid,
labelPosition: 'beside-icon',
showLabel: Styles.isTablet,
get style() {
return {backgroundColor: Styles.globalColors.blueDarkOrGreyDarkest}
Expand Down

0 comments on commit 94e047b

Please sign in to comment.