Probably fixed a bug with the jukebox fades applying instantly the

target volue (finished condition check was reversed), also removed some old commented out code
turoni · Dec 14, 2020 · 2f71a15 · 2f71a15
1 parent 5e138ec
commit 2f71a15
Showing 1 changed file with 2 additions and 12 deletions.
diff --git a/src/general/Jukebox.cs b/src/general/Jukebox.cs
@@ -126,16 +126,6 @@ public override void _Process(float delta)
             if (operations.Peek().Action(delta))
                 operations.Dequeue();
         }
-
-        // // Check if a stream has ended
-        // foreach (var player in audioPlayers)
-        // {
-        //     if (!player.Playing)
-        //     {
-        //         OnSomeTrackEnded();
-        //         break;
-        //     }
-        // }
     }
 
     private void UpdateStreamsPauseStatus()
@@ -264,7 +254,7 @@ private void AddFadeOut()
 
             bool finished = data.TimeLeft <= 0;
 
-            if (finished)
+            if (!finished)
             {
                 AdjustVolume(FADE_PER_TIME_UNIT * delta);
             }
@@ -286,7 +276,7 @@ private void AddFadeIn()
 
             bool finished = data.TimeLeft <= 0;
 
-            if (finished)
+            if (!finished)
             {
                 AdjustVolume(-1 * FADE_PER_TIME_UNIT * delta);
             }