Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #140

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Cleanup #140

merged 2 commits into from
Nov 8, 2023

Conversation

rekt-hard
Copy link
Collaborator

@rekt-hard rekt-hard commented Oct 6, 2023

Description

Fix most of the issues reported by sonar on the latest commit of the next branch.
Update config files for formatter prettier and format files.

What does this PR do?

Logic wise, everything should behave the same.

Breaking changes

Code review focus

Dependencies

Checks

  • Summary updated
  • Version view updated
  • Documentation added
  • Tests added
  • E2e tests created
  • Successfully ran e2e tests before merge

@rekt-hard rekt-hard force-pushed the cleanup branch 2 times, most recently from f0c07ef to fdac38b Compare October 6, 2023 12:39
@rekt-hard rekt-hard requested a review from lpandath October 6, 2023 13:13
@lpandath
Copy link
Collaborator

@rekt-hard Great work on the cleanup! To further automate the process, how about adding the following prettier commands in our script?

"format": "prettier --write .",
  "format:check": "prettier --check .",

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

67.0% 67.0% Coverage
8.9% 8.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Collaborator

@lpandath lpandath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@rekt-hard rekt-hard merged commit 56bab87 into next Nov 8, 2023
3 of 4 checks passed
@rekt-hard rekt-hard deleted the cleanup branch November 16, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants