Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assets: provide fonts and icons locally #181

Merged
merged 1 commit into from
Mar 13, 2024
Merged

assets: provide fonts and icons locally #181

merged 1 commit into from
Mar 13, 2024

Conversation

rekt-hard
Copy link
Collaborator

@rekt-hard rekt-hard commented Mar 12, 2024 •
edited
Loading

Description

Refactoring

What does this PR do?

Remove the inclusion of remote assets, which would perform a request to another domain.
Provide fonts and icons locally.

Reference: https://developers.google.com/fonts/docs/material_icons#what_are_material_icons

Breaking changes

Code review focus

Dependencies

Checks

  • Summary updated
  • Version view updated
  • Documentation added
  • Tests added
  • E2e tests created
  • Successfully ran e2e tests before merge

closes #179

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

ValentinFutterer
ValentinFutterer approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@ValentinFutterer ValentinFutterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, runs good on Chrome and Firefox.

@rekt-hard rekt-hard merged commit 68eb354 into next Mar 13, 2024
2 of 3 checks passed
@rekt-hard rekt-hard deleted the 179-move-from-google-assets-to-own-assets branch June 13, 2024 14:47
@ValentinFutterer ValentinFutterer mentioned this pull request Jul 3, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentinFutterer ValentinFutterer ValentinFutterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move from google assets to own assets
2 participants
@rekt-hard @ValentinFutterer