Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin UI: Add banner and banner setup in Admin UI #404

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Admin UI: Add banner and banner setup in Admin UI #404

merged 1 commit into from
Jan 21, 2025

Conversation

GeoffreyKarnbach
Copy link
Contributor

@GeoffreyKarnbach GeoffreyKarnbach commented Dec 18, 2024 •
edited
Loading

Description

Feature

What does this PR do?

Add possibility to created / edit / display and delete a custom banner in DAMAP.

Dependencies

Backend PR:
tuwien-csd/damap-backend#311

Checks

  • Summary updated
  • Version view updated
  • Documentation added
  • Tests added
  • E2e tests created
  • Successfully ran e2e tests before merge

closes GH-363

@GeoffreyKarnbach GeoffreyKarnbach linked an issue Dec 18, 2024 that may be closed by this pull request
Admin UI: Banner #363
Closed
@GeoffreyKarnbach GeoffreyKarnbach mentioned this pull request Dec 18, 2024
Merged
andresTabiTuwien
andresTabiTuwien reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@andresTabiTuwien andresTabiTuwien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a banner is deleted It is visible in the Admin UI until the full page is reloaded.
image
image
image

It should not be visible after a delete operation is performed.

@GeoffreyKarnbach GeoffreyKarnbach force-pushed the gk/363-admin-ui-banner branch 2 times, most recently from 56e441c to 5110956 Compare January 15, 2025 09:14
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

andresTabiTuwien
andresTabiTuwien approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@andresTabiTuwien andresTabiTuwien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The banner feature works well. Thanks

@andresTabiTuwien andresTabiTuwien merged commit 8a4a8ef into next Jan 21, 2025
3 of 4 checks passed
@andresTabiTuwien andresTabiTuwien deleted the gk/363-admin-ui-banner branch January 21, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresTabiTuwien andresTabiTuwien andresTabiTuwien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin UI: Banner
2 participants
@GeoffreyKarnbach @andresTabiTuwien