Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making my fan work which uses the tuya legacy fan API #162

Closed
wants to merge 1 commit into from

Conversation

tbratfisch
Copy link

These changes make my fan work that uses the legacy API, so the changes are tested using a real device.
I've seen the pull request from @vookimedlo after finishing coding and tested it, but that code doesn't work for me, it looks like the API is reporting wrong values for the legacy API - the API and the documentation are conflicting, see my comments in my changes.

@tbratfisch tbratfisch mentioned this pull request Jul 21, 2021
@vookimedlo
Copy link
Contributor

@tbratfisch I will get back to you during the weekend. I am busy right now. I have some comments to your implementation, but I would say we can find a working solution together.

@vookimedlo
Copy link
Contributor

Meanwhile, 1.4.0 changed the implementation of Fan speed - it has broken the Air Purifier support as I described here #228. I closed my original PR #154 because it is no more relevant.

@tetsuo55
Copy link

@tbratfisch @vookimedlo @mouth4war

We managed to get my fan speeds working in #490 (at the time I'm writing this there is one change missing in the pr itself but mentioned in the comments).

Now my fan uses another way of setting speeds but this new code should support all 3 speed types

That pr (just fan.py) should also work for your fans, could you test?

@zlinoliver
Copy link
Contributor

Hi @tbratfisch , the Tuya developer team really appreciates your contributions and efforts to this Tuya v2 integration project. As we stop maintaining it now, please help to recreate your pull request in the Home Assistant Core repository: https://github.com/home-assistant/core/tree/dev/homeassistant/components/tuya

@zlinoliver zlinoliver closed this Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants