Skip to content

Commit

Permalink
s/onunhandledpromiserejection/onunhandledrejection/g and minor handle…
Browse files Browse the repository at this point in the history
…r fixes
  • Loading branch information
kamilogorek committed Aug 2, 2018
1 parent 8853d2b commit 673b65c
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 17 deletions.
4 changes: 0 additions & 4 deletions packages/browser/src/backend.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,6 @@ export class BrowserBackend implements Backend {
},
};

console.log(event);

return event;
}

Expand All @@ -127,8 +125,6 @@ export class BrowserBackend implements Backend {
};
}

console.log(event);

return event;
}

Expand Down
12 changes: 5 additions & 7 deletions packages/browser/src/integrations/globalhandlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ export class GlobalHandlers implements Integration {
public constructor(
private options: {
onerror: boolean;
onunhandledpromiserejection: boolean;
onunhandledrejection: boolean;
} = {
onerror: true,
onunhandledpromiserejection: true,
onunhandledrejection: true,
},
) {}
/**
Expand Down Expand Up @@ -51,24 +51,22 @@ export class GlobalHandlers implements Integration {
installGlobalHandler();
}

if (this.options.onunhandledpromiserejection) {
logger.log('Global Handler attached: onunhandledpromiserejection');
if (this.options.onunhandledrejection) {
logger.log('Global Handler attached: onunhandledrejection');
installGlobalUnhandledRejectionHandler();
}
}

/** TODO */
private eventFromGlobalHandler(stacktrace: TraceKitStackTrace): SentryEvent {
const event = eventFromStacktrace(stacktrace);
console.log(event);
// TODO: Make a distinction between 'onunhandledrejection' and 'onerror'
return {
...event,
exception: {
...event.exception,
mechanism: {
handled: false,
type: 'onerror',
type: stacktrace.mode === 'onerror' ? 'onerror' : 'onunhandledrejection',
},
},
};
Expand Down
15 changes: 9 additions & 6 deletions packages/browser/src/parsers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,18 @@ export function prepareFramesForEvent(stack: TraceKitStackFrame[]): StackFrame[]
return [];
}

return stack
.filter(
// TODO: This could be smarter
frame => !frame.func.includes('captureMessage') && !frame.func.includes('captureException'),
)
let localStack = stack;

// TODO: This could be smarter
if (localStack[0].func.includes('captureMessage') || localStack[0].func.includes('captureException')) {
localStack = localStack.slice(1);
}

return localStack
.map(
(frame: TraceKitStackFrame): StackFrame => ({
colno: frame.column,
filename: frame.url || stack[0].url,
filename: frame.url || localStack[0].url,
function: frame.func || '?',
in_app: true,
lineno: frame.line,
Expand Down

0 comments on commit 673b65c

Please sign in to comment.