[internal] Ignore empty rule sets. (pantsbuild#17580)

tweag · Nov 18, 2022 · 7583d1e · 7583d1e
1 parent 71a6833
commit 7583d1e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/python/pants/backend/visibility/rule_types.py b/src/python/pants/backend/visibility/rule_types.py
@@ -241,7 +241,7 @@ def set_dependency_rules(
         **kwargs,
     ) -> None:
         try:
-            self.rulesets = [VisibilityRuleSet.parse(arg) for arg in args]
+            self.rulesets = [VisibilityRuleSet.parse(arg) for arg in args if arg]
             self.path = build_file
         except ValueError as e:
             raise BuildFileVisibilityRulesError(f"{build_file}: {e}") from e

diff --git a/src/python/pants/backend/visibility/rule_types_test.py b/src/python/pants/backend/visibility/rule_types_test.py
@@ -367,6 +367,10 @@ def test_dependency_rules(rule_runner: RuleRunner, caplog) -> None:
 
           # Allow all by default, with a warning
           ("*", "?*"),
+
+          # Ignore (accept) empty values as no-op
+          None,
+          (),
         )
 
         __dependents_rules__(