Add policyDefinitionReferenceId duplication test (#25)

tyconsulting · May 9, 2024 · 41ee16b · 41ee16b
1 parent c24df51
commit 41ee16b
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -2,3 +2,5 @@ coverage.xml
 testResults.xml
 .DS_Store
 *.test.xml
+*test*.xml
+*TEST*.xml
diff --git a/AzPolicyTest/AzPolicyTest.nuspec b/AzPolicyTest/AzPolicyTest.nuspec
@@ -2,7 +2,7 @@
 <package>
   <metadata>
     <id>AzPolicyTest</id>
-    <version>2.3.2</version>
+    <version>2.4.0</version>
     <authors>Tao Yang</authors>
     <owners>TY Consulting Pty Ltd</owners>
     <description>Provides pre-defined pester tests for Azure Policy and Initiative definitions</description>

diff --git a/AzPolicyTest/AzPolicyTest.psd1 b/AzPolicyTest/AzPolicyTest.psd1
diff --git a/AzPolicyTest/policySetDefStructure.tests.ps1 b/AzPolicyTest/policySetDefStructure.tests.ps1
@@ -4,7 +4,14 @@ Param (
   [Parameter(Mandatory = $false)][string[]]$excludePath
 )
 Write-Verbose "Path: '$Path'"
-
+function CountPolicyDefinitionReferenceId {
+  param(
+    [object] $policySetObject,
+    [string] $policyDefinitionReferenceId
+  )
+  $policy = $policySetObject.properties.policyDefinitions | where-object {$_.policyDefinitionReferenceId -ieq $policyDefinitionReferenceId}
+  $policy.count
+}
 function IsParameterInUse {
   param(
     [object] $policySetObject,
@@ -304,6 +311,7 @@ Foreach ($file in $files) {
 
         $policyDefinitionTestCase = @{
           policyDefinition = $policyDefinition
+          policyDefinitionReferenceIdCount = CountPolicyDefinitionReferenceId -policySetObject $json -policyDefinitionReferenceId $policyDefinition.policyDefinitionReferenceId
         }
 
         It "$policyDefTestTitle must contain 'policyDefinitionId' element" -TestCases $policyDefinitionTestCase -Tag 'PolicyDefinitionIdExists' {
@@ -333,7 +341,13 @@ Foreach ($file in $files) {
           )
           $policyDefinition.policyDefinitionReferenceId.length | Should -BeGreaterThan 0
         }
-
+        It "'policyDefinitionReferenceId' in $policyDefTestTitle must be only used One (1) time" -TestCases $policyDefinitionTestCase -Tag 'noDuplicatePolicyDefinitionReferenceId' {
+          param(
+            [object] $policyDefinition,
+            [int]$policyDefinitionReferenceIdCount
+          )
+          $policyDefinitionReferenceIdCount | Should -Be 1
+        }
         It "$policyDefTestTitle must contain 'parameters' element" -TestCases $policyDefinitionTestCase -Tag 'PolicyDefinitionParameterExists' {
           param(
             [object] $policyDefinition