fix(text-field): fixed a bug where the internal value change listener was not safely guarding types #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was not safely guarding types
|
|
RobJacobs
approved these changes
Feb 14, 2025
samrichardsontylertech
approved these changes
Feb 14, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
The
_onValueChange()method was overloaded for two different types of listeners that provide arguments with different types (InputEventorstring | null). This method was not properly typed to allow for this overload, and therefore caused a regression when #778 was introduced.This PR separates these listeners to be more explicit about what type of change they are handling, as well as introduces a safety check for the
InputEventtype to be even more explicit about the fix for #778.