Add test reproducing foreign key related manager failure #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have broken between 1.3.2 and 1.3.3 as with 1.3.2 this test runs, but on 1.3.3 and higher it fails.
aleksanb
added a commit
to HyreAS/django-stubs
that referenced
this pull request
Jan 31, 2020
This fixes reverse many-to-one managers regressions in our project that were introduced in typeddjango@665f4d8. I've tried to create a reproduce in typeddjango#300 but was unable to do so. This patch makes django-stubs work for us again, perhaps you are able to see why this fix works, because i do not know the reason why my class doesn't have 'objects'.
aleksanb
added a commit
to HyreAS/django-stubs
that referenced
this pull request
Jan 31, 2020
This fixes reverse many-to-one managers regressions in our project that were introduced in typeddjango@665f4d8. I've tried to create a reproduce in typeddjango#300 but was unable to do so. This patch makes django-stubs work for us again, perhaps you are able to see why this fix works, because i do not know the reason why my class doesn't have 'objects'. We use django 3.0.2 and python 3.8.
aleksanb
added a commit
to HyreAS/django-stubs
that referenced
this pull request
Oct 12, 2020
This fixes reverse many-to-one managers regressions in our project that were introduced in typeddjango@665f4d8. I've tried to create a reproduce in typeddjango#300 but was unable to do so. This patch makes django-stubs work for us again, perhaps you are able to see why this fix works, because i do not know the reason why my class doesn't have 'objects'. We use django 3.0.2 and python 3.8.
aleksanb
added a commit
to HyreAS/django-stubs
that referenced
this pull request
Dec 8, 2020
This fixes reverse many-to-one managers regressions in our project that were introduced in typeddjango@665f4d8. I've tried to create a reproduce in typeddjango#300 but was unable to do so. This patch makes django-stubs work for us again, perhaps you are able to see why this fix works, because i do not know the reason why my class doesn't have 'objects'.
aleksanb
added a commit
to HyreAS/django-stubs
that referenced
this pull request
Mar 8, 2021
This fixes reverse many-to-one managers regressions in our project that were introduced in typeddjango@665f4d8. I've tried to create a reproduce in typeddjango#300 but was unable to do so. This patch makes django-stubs work for us again, perhaps you are able to see why this fix works, because i do not know the reason why my class doesn't have 'objects'.
stianjensen
pushed a commit
to HyreAS/django-stubs
that referenced
this pull request
Jun 2, 2021
This fixes reverse many-to-one managers regressions in our project that were introduced in typeddjango@665f4d8. I've tried to create a reproduce in typeddjango#300 but was unable to do so. This patch makes django-stubs work for us again, perhaps you are able to see why this fix works, because i do not know the reason why my class doesn't have 'objects'.
aleksanb
added a commit
to HyreAS/django-stubs
that referenced
this pull request
Nov 3, 2021
This fixes reverse many-to-one managers regressions in our project that were introduced in typeddjango@665f4d8. I've tried to create a reproduce in typeddjango#300 but was unable to do so. This patch makes django-stubs work for us again, perhaps you are able to see why this fix works, because i do not know the reason why my class doesn't have 'objects'.
aleksanb
added a commit
to HyreAS/django-stubs
that referenced
this pull request
Jan 13, 2022
This fixes reverse many-to-one managers regressions in our project that were introduced in typeddjango@665f4d8. I've tried to create a reproduce in typeddjango#300 but was unable to do so. This patch makes django-stubs work for us again, perhaps you are able to see why this fix works, because i do not know the reason why my class doesn't have 'objects'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is roughly the code i have in my repo that broke between 1.3.2 and 1.3.3, but this test passes :( I'll try to add more code to it hoping it'll fail soon.