Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script for merging stubs into Django source files for testing #408

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Script for merging stubs into Django source files for testing #408

wants to merge 12 commits into from

Conversation

kszmigiel
Copy link
Member

kszmigiel and others added 11 commits April 6, 2020 20:24
@kszmigiel
Merge pull request #1 from typeddjango/master
ceeb327 
stub for _build_app_dict (#351)
@kszmigiel
Merge pull request #2 from typeddjango/master
5cf0771 
update
@kszmigiel
Merge pull request #3 from typeddjango/master
c19da10 
Revert "Allow template render to string helper functions to accept Co…
@kszmigiel
Merge pull request #4 from typeddjango/master
c4d9e69 
update master
pytest-mypy-plugins package newer version
871347a
Revert "pytest-mypy-plugins package newer version"
df22fc7 
This reverts commit 871347a.
update tests ignores for django
93fc66e
Revert "update tests ignores for django"
0390dc3 
This reverts commit 93fc66e.
@kszmigiel
Merge pull request #5 from typeddjango/master
9b44e3c 
update master
@kszmigiel
Merge pull request #6 from typeddjango/master
5a51fb2 
update master
initial version of the script
d73e031
@kszmigiel
Copy link
Member Author

@mkurnikov @sobolevn I had not much time to sink into libcst docs yet, so here's just initial version on the script, so you can easily check my progress on this in the nearest future :)

@mkurnikov
Copy link
Member

Looks about right. Now we need to add more steps:

  1. Merge all the stubs into Django sources. This will probably create lots of edge cases, at least that how it was with my experiments with retype from before.
  2. Run mypy on top of annotated Django sources. We can start with whitelisting files to check.
  3. Community call for help, probably. Add it to CI to prevent regressions.

mkurnikov
mkurnikov requested changes Jun 25, 2020
View reviewed changes
scripts/merge_stubs_into_django.py
context = CodemodContext()
visitor = ApplyTypeAnnotationsVisitor(context)

stubs_dir = '../django-stubs'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make paths not .. relative, but with Path(__file__).parent so that script could be run from other directories too.

mkurnikov
mkurnikov reviewed Jun 25, 2020
View reviewed changes
scripts/merge_stubs_into_django.py
for path in stubs_pathlist:
str_path = str(path)

stubs_dict[str_path.split('/', 2)[-1].split('.')[0]] = str_path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here, use pathlib.Path everywhere for filesystem paths.

mkurnikov
mkurnikov reviewed Jun 25, 2020
View reviewed changes
scripts/merge_stubs_into_django.py
if key in stubs_dict:
sources_dict[key] = str_path

for key in stubs_dict:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use enumerate(stubs_dict), you're using values of the dict too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurnikov mkurnikov mkurnikov requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing stubs against Django source code
2 participants
@kszmigiel @mkurnikov