Skip to content

Commit

Permalink
There is no std::errc::success, remove the llvm one.
Browse files Browse the repository at this point in the history
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@209960 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
espindola committed May 31, 2014
1 parent 1028cc7 commit c145fd3
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 9 deletions.
2 changes: 0 additions & 2 deletions include/llvm/Support/system_error.h
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,6 @@ template <class Tp> struct is_error_condition_enum : public std::false_type {};
// for them:

enum class errc {
success = 0,
address_family_not_supported = EAFNOSUPPORT,
address_in_use = EADDRINUSE,
address_not_available = EADDRNOTAVAIL,
Expand Down Expand Up @@ -810,7 +809,6 @@ inline bool operator!=(const error_condition& _x, const error_condition& _y) {
//
// error_code( ::GetLastError(), system_category() )
enum class windows_error {
success = 0,
// These names and values are based on Windows WinError.h
// This is not a complete list. Add to this list if you need to explicitly
// check for it.
Expand Down
2 changes: 1 addition & 1 deletion lib/Object/Error.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ std::string _object_error_category::message(int ev) const {

error_condition _object_error_category::default_error_condition(int ev) const {
if (ev == object_error::success)
return errc::success;
return error_condition();
return errc::invalid_argument;
}

Expand Down
2 changes: 1 addition & 1 deletion lib/ProfileData/InstrProf.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class InstrProfErrorCategoryType : public error_category {
}
error_condition default_error_condition(int EV) const override {
if (EV == instrprof_error::success)
return errc::success;
return error_condition();
return errc::invalid_argument;
}
};
Expand Down
2 changes: 1 addition & 1 deletion lib/Support/LockFileManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ LockFileManager::LockFileManager(StringRef FileName)
// Create a link from the lock file name. If this succeeds, we're done.
error_code EC =
sys::fs::create_link(UniqueLockFileName.str(), LockFileName.str());
if (EC == errc::success)
if (!EC)
return;

if (EC != errc::file_exists) {
Expand Down
4 changes: 2 additions & 2 deletions lib/Support/Unix/Program.inc
Original file line number Diff line number Diff line change
Expand Up @@ -427,12 +427,12 @@ ProcessInfo sys::Wait(const ProcessInfo &PI, unsigned SecondsToWait,

error_code sys::ChangeStdinToBinary(){
// Do nothing, as Unix doesn't differentiate between text and binary.
return make_error_code(errc::success);
return error_code();
}

error_code sys::ChangeStdoutToBinary(){
// Do nothing, as Unix doesn't differentiate between text and binary.
return make_error_code(errc::success);
return error_code();
}

bool llvm::sys::argumentsFitWithinSystemLimits(ArrayRef<const char*> Args) {
Expand Down
2 changes: 1 addition & 1 deletion tools/llvm-readobj/Error.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ std::string _readobj_error_category::message(int ev) const {

error_condition _readobj_error_category::default_error_condition(int ev) const {
if (ev == readobj_error::success)
return errc::success;
return error_condition();
return errc::invalid_argument;
}

Expand Down
2 changes: 1 addition & 1 deletion tools/obj2yaml/Error.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ std::string _obj2yaml_error_category::message(int ev) const {
error_condition
_obj2yaml_error_category::default_error_condition(int ev) const {
if (ev == obj2yaml_error::success)
return errc::success;
return error_condition();
return errc::invalid_argument;
}

Expand Down

0 comments on commit c145fd3

Please sign in to comment.