Encode key when value is null (sindresorhus#67)

* Encode key when value is null * Use is instead of deepEqual in stringify tests
uangsl · Jun 12, 2016 · 62419bd · 62419bd
1 parent df17d8e
commit 62419bd
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 20 deletions.
diff --git a/index.js b/index.js
@@ -70,7 +70,7 @@ exports.stringify = function (obj, opts) {
 		}
 
 		if (val === null) {
-			return key;
+			return encode(key, opts);
 		}
 
 		if (Array.isArray(val)) {

diff --git a/test/stringify.js b/test/stringify.js
@@ -2,62 +2,62 @@ import test from 'ava';
 import fn from '../';
 
 test('stringify', t => {
-	t.deepEqual(fn.stringify({foo: 'bar'}), 'foo=bar');
-	t.deepEqual(fn.stringify({foo: 'bar', bar: 'baz'}), 'bar=baz&foo=bar');
+	t.is(fn.stringify({foo: 'bar'}), 'foo=bar');
+	t.is(fn.stringify({foo: 'bar', bar: 'baz'}), 'bar=baz&foo=bar');
 });
 
 test('different types', t => {
-	t.deepEqual(fn.stringify(), '');
-	t.deepEqual(fn.stringify(0), '');
+	t.is(fn.stringify(), '');
+	t.is(fn.stringify(0), '');
 });
 
 test('URI encode', t => {
-	t.deepEqual(fn.stringify({'foo bar': 'baz faz'}), 'foo%20bar=baz%20faz');
-	t.deepEqual(fn.stringify({'foo bar': 'baz\'faz'}), 'foo%20bar=baz%27faz');
+	t.is(fn.stringify({'foo bar': 'baz faz'}), 'foo%20bar=baz%20faz');
+	t.is(fn.stringify({'foo bar': 'baz\'faz'}), 'foo%20bar=baz%27faz');
 });
 
 test('no encoding', t => {
-	t.deepEqual(fn.stringify({'foo:bar': 'baz:faz'}, {encode: false}), 'foo:bar=baz:faz');
+	t.is(fn.stringify({'foo:bar': 'baz:faz'}, {encode: false}), 'foo:bar=baz:faz');
 });
 
 test('handle array value', t => {
-	t.deepEqual(fn.stringify({abc: 'abc', foo: ['bar', 'baz']}), 'abc=abc&foo=bar&foo=baz');
+	t.is(fn.stringify({abc: 'abc', foo: ['bar', 'baz']}), 'abc=abc&foo=bar&foo=baz');
 });
 
 test('array order', t => {
-	t.deepEqual(fn.stringify({abc: 'abc', foo: ['baz', 'bar']}), 'abc=abc&foo=baz&foo=bar');
+	t.is(fn.stringify({abc: 'abc', foo: ['baz', 'bar']}), 'abc=abc&foo=baz&foo=bar');
 });
 
 test('handle empty array value', t => {
-	t.deepEqual(fn.stringify({abc: 'abc', foo: []}), 'abc=abc');
+	t.is(fn.stringify({abc: 'abc', foo: []}), 'abc=abc');
 });
 
 test('should not encode undefined values', t => {
-	t.deepEqual(fn.stringify({abc: undefined, foo: 'baz'}), 'foo=baz');
+	t.is(fn.stringify({abc: undefined, foo: 'baz'}), 'foo=baz');
 });
 
 test('should encode null values as just a key', t => {
-	t.deepEqual(fn.stringify({xyz: null, abc: null, foo: 'baz'}), 'abc&foo=baz&xyz');
+	t.is(fn.stringify({'x y z': null, 'abc': null, 'foo': 'baz'}), 'abc&foo=baz&x%20y%20z');
 });
 
 test('handle null values in array', t => {
-	t.deepEqual(fn.stringify({foo: null, bar: [null, 'baz']}), 'bar&bar=baz&foo');
+	t.is(fn.stringify({foo: null, bar: [null, 'baz']}), 'bar&bar=baz&foo');
 });
 
 test('handle undefined values in array', t => {
-	t.deepEqual(fn.stringify({foo: null, bar: [undefined, 'baz']}), 'bar=baz&foo');
+	t.is(fn.stringify({foo: null, bar: [undefined, 'baz']}), 'bar=baz&foo');
 });
 
 test('handle undefined and null values in array', t => {
-	t.deepEqual(fn.stringify({foo: null, bar: [undefined, null, 'baz']}), 'bar&bar=baz&foo');
+	t.is(fn.stringify({foo: null, bar: [undefined, null, 'baz']}), 'bar&bar=baz&foo');
 });
 
 test('strict encoding', t => {
-	t.deepEqual(fn.stringify({foo: '\'bar\''}), 'foo=%27bar%27');
-	t.deepEqual(fn.stringify({foo: ['\'bar\'', '!baz']}), 'foo=%27bar%27&foo=%21baz');
+	t.is(fn.stringify({foo: '\'bar\''}), 'foo=%27bar%27');
+	t.is(fn.stringify({foo: ['\'bar\'', '!baz']}), 'foo=%27bar%27&foo=%21baz');
 });
 
 test('loose encoding', t => {
-	t.deepEqual(fn.stringify({foo: '\'bar\''}, {strict: false}), 'foo=\'bar\'');
-	t.deepEqual(fn.stringify({foo: ['\'bar\'', '!baz']}, {strict: false}), 'foo=\'bar\'&foo=!baz');
+	t.is(fn.stringify({foo: '\'bar\''}, {strict: false}), 'foo=\'bar\'');
+	t.is(fn.stringify({foo: ['\'bar\'', '!baz']}, {strict: false}), 'foo=\'bar\'&foo=!baz');
 });