Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Example: get rid of the backwards yaru.dart dependency #20

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Example: get rid of the backwards yaru.dart dependency #20

merged 1 commit into from
Feb 9, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Feb 9, 2023

The example must depend on yaru_colors from path to be able to use API available in the local checkout. It didn't do that because:

Running "flutter pub get" in example...
Resolving dependencies...
Because yaru_colors_example depends on yaru ^0.3.0 which depends on yaru_colors ^0.1.0, yaru_colors from hosted is required.
So, because yaru_colors_example depends on yaru_colors from path, version solving failed.
pub get failed

The yaru dependency is unnecessary so instead of hacking around it with overrides, just remove it. After all, the purpose of this example is to present the color palettes, not how the theme looks. ;)

@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 9, 2023

This should help #19 pass the CI.

@jpnurmi jpnurmi merged commit f93c7a6 into ubuntu:main Feb 9, 2023
@jpnurmi jpnurmi deleted the example-yaru branch February 9, 2023 13:08
@jpnurmi jpnurmi mentioned this pull request Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants