Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(datasets): unauthorized call return 200 #118

Merged
merged 1 commit into from
Mar 7, 2019
Merged

chore(datasets): unauthorized call return 200 #118

merged 1 commit into from
Mar 7, 2019

Conversation

philloooo
Copy link
Contributor

@philloooo philloooo commented Mar 6, 2019 •
edited
Loading

Description about what this pull request does.

Please make sure to follow the DEV guidelines before asking for review.

New Features

  • make authenticated but not authorized requests to datasets endpoint return 200

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

@PlanXCyborg
Copy link

Jenkins Build 1 : time taken 3 min 13 sec
Check the https://jenkins.planx-pla.net/job/perf-peregrine/job/PR-118/1/display/redirect

@PlanXCyborg
Copy link

Jenkins Build 2 : time taken 16 min
Check the https://jenkins.planx-pla.net/job/perf-peregrine/job/PR-118/2/display/redirect

qingyashu
qingyashu approved these changes Mar 6, 2019
View reviewed changes
Copy link

@qingyashu qingyashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me, also tested in my dev env and it works!

@PlanXCyborg
Copy link

Jenkins Build 3 : time taken 1 hr 55 min
Check the https://jenkins.planx-pla.net/job/perf-peregrine/job/PR-118/3/display/redirect

@philloooo philloooo merged commit 797558c into master Mar 7, 2019
@philloooo philloooo deleted the chore/datasets branch March 7, 2019 00:46
paulineribeyre pushed a commit that referenced this pull request Mar 7, 2019
@philloooo @paulineribeyre
chore(datasets): unauthorized call return 200 (#118)
85204f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingyashu qingyashu qingyashu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philloooo @PlanXCyborg @qingyashu