Fix bug in RNN where hprev always referred to start. Change so that h…

…prev refers to output of previous cell
uccmen · Sep 15, 2022 · bf38625 · bf38625
1 parent 2f5e8d7
commit bf38625
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/makemore.py b/makemore.py
@@ -330,6 +330,7 @@ def forward(self, idx, targets=None):
         for i in range(t):
             xt = emb[:, i, :] # (b, n_embd)
             ht = self.cell(xt, hprev) # (b, n_embd2)
+            hprev = ht
             hiddens.append(ht)
 
         # decode the outputs