Skip to content

Commit

Permalink
Refactor scene-graph (google#1692)
Browse files Browse the repository at this point in the history
* moving useful 3dom pieces into model-viewer

* simplified

* make tests compile

* materials in array order, with default

* moved scene-graph folder

* removed 3dom dependency

* added tests

* remove unused

* removed modelGraft

* added onUpdate callback

* removed 3dom package

* disable linting, as it was only used on 3dom

* fix IE11 tests

* added renderCount to scene for easier testing and debug

* fix teardown

* removed duplicate tests

* add test logging

* maybe a problem with intersectionObserver?
  • Loading branch information
elalish authored Nov 6, 2020
1 parent 9fecc68 commit 3f8f267
Show file tree
Hide file tree
Showing 87 changed files with 580 additions and 57,591 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/deploy-documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ jobs:
- name: NPM install
run: npm ci

- name: Lint TypeScript sources
run: npm run lint
# - name: Lint TypeScript sources
# run: npm run lint

- name: Bootstrap packages
run: npm run bootstrap
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/fidelity-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,14 @@ jobs:
- name: NPM install
run: npm ci

- name: Lint TypeScript sources
run: npm run lint
# - name: Lint TypeScript sources
# run: npm run lint

- name: Bootstrap packages
run: npm run bootstrap

- name: Build packages
run: |
./node_modules/.bin/lerna run --scope @google/3dom build --stream
./node_modules/.bin/lerna run --scope @google/model-viewer build --stream
./node_modules/.bin/lerna run --scope @google/model-viewer-render-fidelity-tools build --stream
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit-tests-third-party.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ jobs:
- name: NPM install
run: npm ci

- name: Lint TypeScript sources
run: npm run lint
# - name: Lint TypeScript sources
# run: npm run lint

- name: Bootstrap packages
run: npm run bootstrap
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ jobs:
- name: NPM install
run: npm ci

- name: Lint TypeScript sources
run: npm run lint
# - name: Lint TypeScript sources
# run: npm run lint

- name: Bootstrap packages
run: npm run bootstrap
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ Check out the README.md files for specific projects to get more details:

🎨 **[shared-assets](packages/shared-assets)** • 3D models, environment maps and other assets shared across many sub-projects

📦 **[3DOM](packages/3dom)** • A generic glTF scene graph API that enables operations on 3D models while abstracting the in-memory representation.

## Development

When developing across all the projects in this repository, first install git,
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
},
"husky": {
"hooks": {
"pre-commit": "npm run lint && ./scripts/pre-commit.sh"
"pre-commit": "./scripts/pre-commit.sh"
}
},
"repository": {
Expand Down Expand Up @@ -48,4 +48,4 @@
"typescript": "4.0.3"
},
"dependencies": {}
}
}
6 changes: 0 additions & 6 deletions packages/3dom/.gitignore

This file was deleted.

202 changes: 0 additions & 202 deletions packages/3dom/LICENSE

This file was deleted.

66 changes: 0 additions & 66 deletions packages/3dom/README.md

This file was deleted.

1 change: 0 additions & 1 deletion packages/3dom/demo/add_photo_alternate-white-18dp.svg

This file was deleted.

Loading

0 comments on commit 3f8f267

Please sign in to comment.