Skip to content

Commit

Permalink
net: mdio: xgene: Fix unused xgene_mdio_of_match warning for !CONFIG_OF
Browse files Browse the repository at this point in the history
Commit a243ecc ("net: mdio: xgene: Use device_get_match_data()")
dropped the unconditional use of xgene_mdio_of_match resulting in this
warning:

drivers/net/mdio/mdio-xgene.c:303:34: warning: unused variable 'xgene_mdio_of_match' [-Wunused-const-variable]

The fix is to drop of_match_ptr() which is not necessary because DT is
always used for this driver (well, it could in theory support ACPI only,
but CONFIG_OF is always enabled for arm64).

Fixes: a243ecc ("net: mdio: xgene: Use device_get_match_data()")
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Rob Herring <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
  • Loading branch information
robherring authored and kuba-moo committed Oct 23, 2023
1 parent c0119e6 commit d6e4846
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/mdio/mdio-xgene.c
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ static void xgene_mdio_remove(struct platform_device *pdev)
static struct platform_driver xgene_mdio_driver = {
.driver = {
.name = "xgene-mdio",
.of_match_table = of_match_ptr(xgene_mdio_of_match),
.of_match_table = xgene_mdio_of_match,
.acpi_match_table = ACPI_PTR(xgene_mdio_acpi_match),
},
.probe = xgene_mdio_probe,
Expand Down

0 comments on commit d6e4846

Please sign in to comment.