-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated templates for tn to use 4.2.4 with updated reference (dev) #335
Conversation
Also added in enable hrd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
QA steps
(FYI Flo @reisingerf; how to - basic/blackbox verification)
export AWS_PROFILE=dev
ice
- Assert file exists
ica files get gds://development/reference-data/dragen_hash_tables/v9-r3/hg38-alt_masked-cnv-hla-rna/hg38-alt_masked.cnv.hla.rna-9-r3.0-1.tar.gz
- Assert version exists
ica workflows versions list wfl.a4056543ef9a474d8b16182a4e6b6c50
ID NAME LANGUAGE STATUS TIMECREATED
wfv.4e5ffa0c71e24d4aa094a89355900e14 4.2.4 CWL Draft 2023-07-21 12:34:38.813 +1000 AEST
wfv.3cffcea8169b4ddc90f97389b9f1c0ff 3.9.3 CWL Draft 2023-03-04 13:31:10.855 +1100 AEDT
wfv.b1c15373c5c04d809aa149235b1973bb 4.0.3 CWL Draft 2022-10-04 18:32:03.244 +1100 AEDT
- Check workflow / pipeline name (to search in Catalogue, next)
ica workflows get wfl.a4056543ef9a474d8b16182a4e6b6c50 | grep name
name dragen-somatic-with-germline-pipeline_dev-wf
- Go to https://github.com/umccr/cwl-ica/blob/main/cwl-ica-catalogue.md
- Browser search
dragen-somatic-with-germline-pipeline
- .. in turn https://github.com/umccr/cwl-ica/blob/main/cwl-ica-catalogue.md#dragen-somatic-with-germline-pipeline
- .. in turn https://github.com/umccr/cwl-ica/blob/main/.github/catalogue/docs/workflows/dragen-somatic-with-germline-pipeline/4.2.4/dragen-somatic-with-germline-pipeline__4.2.4.md
- Assert that all workflow input (existing and new changes) are conformant with Automation
...
We could Github Action script it on PR action. However. Human manual QA is also preferable. So, it is and holding that thought for now. We can do something better in OrcaBus, I suppose...
Awesome! Thanks! |
Added enable_map_align_output_germline and set to false Added enable_sv_germline and set to false
Same here. If you'd like us to give another look, pls click "re-request review" .. then I will go through again. Otherwise, happy for you to merge in. It is for dev; so not much of worry. If it breaks a thing or 2; make another PR to fix it. Rinse & spin, etc. 🙂 |
Happy to keep out in PR until you're ready to run E2E tests and have run |
@victorskl I forgot about this tool, ica-check-cwl-inputs Nest input json under 'input'jq -r '{ "input": . }' <<< '{
"output_file_prefix_germline": null,
"output_file_prefix_somatic": null,
"output_directory_germline": null,
"output_directory_somatic": null,
"fastq_list_rows": [],
"tumor_fastq_list_rows": [],
"enable_map_align_output": true,
"enable_map_align_output_germline": false,
"enable_duplicate_marking": true,
"enable_sv": true,
"enable_sv_germline": false,
"cnv_use_somatic_vc_baf": true,
"enable_cnv": true,
"enable_hrd": true,
"reference_tar": {
"class": "File",
"location": "gds://development/reference-data/dragen_hash_tables/v9-r3/hg38-alt_masked-cnv-hla-rna/hg38-alt_masked.cnv.hla.rna-9-r3.0-1.tar.gz"
}
}' > input.json Run ica-check-cwl-inputs
Gives us
|
DRAGEN-4 upgrade is a go. Merging... |
Also added in enable hrd