-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added permissions for s3 copy to have permission to write to cache bucket #531
base: master
Are you sure you want to change the base?
Added permissions for s3 copy to have permission to write to cache bucket #531
Conversation
Should we limit it to a "sharing" keyspace in the bucket.. |
Sure, or a 'restore' keyspace? |
Yes -name to be decided .. "restore" sounds good. @reisingerf ? |
So the Get and List should be *, and the Put and Delete restricted I think. |
Also, "s3:GetObjectVersion" seems to be missing from the lists.. if GetObjectVersionTagging is there - so should the ability to get the actual versioned objects too |
Yes, a restriction to a "restore" prefix would be good. Also happy with 'restore' or perhaps better 'restored' as it sounds more of a fact and less of a ToDo. As for the permissions, they are probably a bit too generous. I don't think we need to deal with version (of tags nor objects). Versioning at the moment is an emergency backup in case something went wrong and then it generally requires an admin to sort things out. |
Updated, split read / write statements and added restore prefix to write roles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #530