-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Featured content on homepage doesn't match V1 featured content #645
Comments
Yes that seems the same to me.
From a standpoint of how the homepage appears, for V2 we would want EITHER 1 or 2 but not both. The settings which achieve that will of course be different in V2. |
V2 currently only allows embedded questionnaires on the homepage. For polls that probably makes sense as a default, but for surveys and quizzes it might be more sensible to have page links instead? --> Respect the 'direct display' flag and display accordingly |
I can't make sense of how this is done in V1. Example:
I can't make sense of this either. @cbunicef any insights? |
Let's continue to give administrators the flexibility to embed questionnaires on any section via "Direct Display". |
Had to do a lot of testing on this one, but I'm pretty sure the answer in the end is simple. There are only X (looks like 5) possible promoted articles per top-level section eg "Youth". The X most recent promoted articles are shown. In sections with fewer than X promoted articles only those promoted are shown, eg "COVID-19" section. Promoted articles dates inherit from the main language, and empty or different promotion dates on the translation pages don't have an impact. The content is different between languages because the newer articles which are promoted in English aren't translated to Russian, so on the Russian page only the most recent articles with translation are shown. One thing I don't understand is that even though I've added a recent promotion date to this article, it doesn't appear on the homepage.
I've tested a number of things was also stumped. In the end I copied the Page, changed slugs so that it has the same URL as the original T&Cs Page. That new Page appears in the footer. Maybe some bad data in the database? |
Thanks, that is helpful. Should we also truncate at 5 articles per section for the purpose of migration, or display all of them? It is extremely fast to deleted unwanted featured content, so maybe having all of them it safer? For the T&Cs, could it be that the slug is hard-coded not to be displayed? Either way, I suggest we migrate all footers for now? |
Reopening as some tasks are still to be done. |
Noting that this should be from MAIN language, not English
It wouldn't be related to migration, but we should have max 5 promoted articles per section displayed.
I meant that when I made a copy of the Footer Page, and changed it to the original slug name, it displayed: I don't think there was anything preventing the Footer Page from being listed, except that it was that particular unique Footer Page. So maybe a database error somewhere, but fixed now by creating the new copy. |
This is done, modulo footer issues which are tracked in #732 |
New specification of desired behavior:
Footers:
Featured content:
Current state (outdated):
The text was updated successfully, but these errors were encountered: