Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds polls and surveys from index pages to home page featured content #673

Merged

Conversation

sheralim012
Copy link
Contributor

@sheralim012 sheralim012 commented Oct 20, 2021

addresses part of #645

  • added new embedded questionnaires block for homepage featured content and article body
    • it has 2 fields, questionnaire and direct display option
  • adds polls from index page as featured content of home page
  • adds surveys from index page as featured content of home page
  • only live polls and surveys are added as featured content
  • polls will be migrated with direct display on
  • surveys will migrated with direct display on/off (according to v1)

@sheralim012 sheralim012 force-pushed the enh/add-polls-surveys-to-featured-content branch from 03cdc54 to be1f5ba Compare October 20, 2021 09:45
@sheralim012 sheralim012 force-pushed the enh/add-polls-surveys-to-featured-content branch from be1f5ba to 875b86d Compare October 20, 2021 09:51
@geoo89 geoo89 linked an issue Oct 22, 2021 that may be closed by this pull request
9 tasks
@geoo89
Copy link
Contributor

geoo89 commented Oct 22, 2021

This works nicely, but with V2 features in mind I'd like the following change:

Currently, we have a featured content block called 'embedded survey' which then might display a linked survey, which is misleading.
We should have featured content blocks 'Poll' and 'Embedded Poll', 'Survey' and 'Embedded Survey', 'Quiz' and 'Embedded Quiz', which you can then use for the featured content from V1 accordingly. The reason is that in V2 also surveys that are not in the index page may be featured, and the direct display flag determines how they show up in their section, which might be different from how we want to display them in the featured content. I updated the specification in #645 accordingly.

@sheralim012 sheralim012 force-pushed the enh/add-polls-surveys-to-featured-content branch from a1331db to 538e40b Compare October 25, 2021 10:07
@sheralim012 sheralim012 force-pushed the enh/add-polls-surveys-to-featured-content branch from 538e40b to 9afbaad Compare October 25, 2021 10:08
@sheralim012
Copy link
Contributor Author

This works nicely, but with V2 features in mind I'd like the following change:

Currently, we have a featured content block called 'embedded survey' which then might display a linked survey, which is misleading. We should have featured content blocks 'Poll' and 'Embedded Poll', 'Survey' and 'Embedded Survey', 'Quiz' and 'Embedded Quiz', which you can then use for the featured content from V1 accordingly. The reason is that in V2 also surveys that are not in the index page may be featured, and the direct display flag determines how they show up in their section, which might be different from how we want to display them in the featured content. I updated the specification in #645 accordingly.

updated by replacing old embedded blocks with new embedded blocks

@ehmadzubair ehmadzubair self-requested a review October 27, 2021 06:16
@geoo89 geoo89 merged commit 713779f into unicef:develop Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Featured content on homepage doesn't match V1 featured content
3 participants